From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mmc: Update "mmc->part_num" when performing a partition switch
Date: Tue, 04 Jun 2013 17:30:06 -0600 [thread overview]
Message-ID: <51AE787E.8050604@wwwdotorg.org> (raw)
In-Reply-To: <CAOMZO5A7w=h-FZGaKSsuJW4wfNueQXzZZRZJF=EjLNFjxiqj6w@mail.gmail.com>
On 06/04/2013 05:09 PM, Fabio Estevam wrote:
> On Tue, Jun 4, 2013 at 7:12 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>
>> In env_mmc.c, you'll want something like:
>
> Thanks for the patch, but when I add these changes on top of my patch
> it results in the original error:
Of course; with that patch applied, there is no effective difference in
the code - you've just cleaned it up to have the MMC core manage
mmc->part_num, rather than requiring all callers to update it themselves.
> U-Boot > save
> Saving Environment to MMC...
> Writing to MMC(1)... done
> U-Boot > save
> Saving Environment to MMC...
> MMC partition switch failed
> U-Boot >
I have no idea why that happens. You'll simply have to debug the code.
Do you have CONFIG_SYS_MMC_ENV_PART set? I wasn't aware anyone else used
it, besides Tegra.
next prev parent reply other threads:[~2013-06-04 23:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 19:17 [U-Boot] [PATCH v2] mmc: Update "mmc->part_num" when performing a partition switch Fabio Estevam
2013-06-04 19:21 ` Stephen Warren
2013-06-04 19:30 ` Fabio Estevam
2013-06-04 19:36 ` Stephen Warren
2013-06-04 20:45 ` Fabio Estevam
2013-06-04 22:12 ` Stephen Warren
2013-06-04 23:09 ` Fabio Estevam
2013-06-04 23:30 ` Stephen Warren [this message]
2013-06-04 23:48 ` Fabio Estevam
2013-06-04 23:16 ` Fabio Estevam
2013-06-04 23:31 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AE787E.8050604@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.