From: Dave Hansen <dave@sr71.net>
To: Minchan Kim <minchan@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, mgorman@suse.de,
tim.c.chen@linux.intel.com
Subject: Re: [v5][PATCH 6/6] mm: vmscan: drain batch list during long operations
Date: Tue, 04 Jun 2013 16:31:15 -0700 [thread overview]
Message-ID: <51AE78C3.1040500@sr71.net> (raw)
In-Reply-To: <20130604232315.GA31006@blaptop>
On 06/04/2013 04:23 PM, Minchan Kim wrote:
> On Tue, Jun 04, 2013 at 08:24:38AM -0700, Dave Hansen wrote:
>> On 06/03/2013 11:05 PM, Minchan Kim wrote:
>>>>> This ensures that we drain the batch if we are about to perform a
>>>>> pageout() or congestion_wait(), either of which will take some
>>>>> time. We expect this to help mitigate the worst of the latency
>>>>> increase that the batching could cause.
>>> Nice idea but I could see drain before pageout but congestion_wait?
>>
>> That comment managed to bitrot a bit :(
>>
>> The first version of these had the drain before pageout() only. Then,
>> Mel added a congestion_wait() call, and I modified the series to also
>> drain there. But, some other patches took the congestion_wait() back
>> out, so I took that drain back out.
>
> I am looking next-20130530 and it has still a congestion_wait.
> I'm confusing. :(
>
>
> if (PageWriteback(page)) {
> /* Case 1 above */
> if (current_is_kswapd() &&
> PageReclaim(page) &&
> zone_is_reclaim_writeback(zone)) {
> congestion_wait(BLK_RW_ASYNC, HZ/10);
> zone_clear_flag(zone, ZONE_WRITEBACK);
>>
>> I _believe_ the only congestion_wait() left in there is a cgroup-related
>> one that we didn't think would cause very much harm.
>
> The congestion_wait I am seeing is not cgroup-related one.
Yeah, sorry for the confusion. There's been a whole lot of activity in
there. My set is also done on top of a couple of fixes that Mel posted
later on, including this one:
https://patchwork.kernel.org/patch/2619901/
*That* one removes the congestion_wait() you noticed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@sr71.net>
To: Minchan Kim <minchan@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, mgorman@suse.de,
tim.c.chen@linux.intel.com
Subject: Re: [v5][PATCH 6/6] mm: vmscan: drain batch list during long operations
Date: Tue, 04 Jun 2013 16:31:15 -0700 [thread overview]
Message-ID: <51AE78C3.1040500@sr71.net> (raw)
In-Reply-To: <20130604232315.GA31006@blaptop>
On 06/04/2013 04:23 PM, Minchan Kim wrote:
> On Tue, Jun 04, 2013 at 08:24:38AM -0700, Dave Hansen wrote:
>> On 06/03/2013 11:05 PM, Minchan Kim wrote:
>>>>> This ensures that we drain the batch if we are about to perform a
>>>>> pageout() or congestion_wait(), either of which will take some
>>>>> time. We expect this to help mitigate the worst of the latency
>>>>> increase that the batching could cause.
>>> Nice idea but I could see drain before pageout but congestion_wait?
>>
>> That comment managed to bitrot a bit :(
>>
>> The first version of these had the drain before pageout() only. Then,
>> Mel added a congestion_wait() call, and I modified the series to also
>> drain there. But, some other patches took the congestion_wait() back
>> out, so I took that drain back out.
>
> I am looking next-20130530 and it has still a congestion_wait.
> I'm confusing. :(
>
>
> if (PageWriteback(page)) {
> /* Case 1 above */
> if (current_is_kswapd() &&
> PageReclaim(page) &&
> zone_is_reclaim_writeback(zone)) {
> congestion_wait(BLK_RW_ASYNC, HZ/10);
> zone_clear_flag(zone, ZONE_WRITEBACK);
>>
>> I _believe_ the only congestion_wait() left in there is a cgroup-related
>> one that we didn't think would cause very much harm.
>
> The congestion_wait I am seeing is not cgroup-related one.
Yeah, sorry for the confusion. There's been a whole lot of activity in
there. My set is also done on top of a couple of fixes that Mel posted
later on, including this one:
https://patchwork.kernel.org/patch/2619901/
*That* one removes the congestion_wait() you noticed.
next prev parent reply other threads:[~2013-06-04 23:31 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 20:02 [v5][PATCH 0/6] mm: vmscan: Batch page reclamation under shink_page_list Dave Hansen
2013-06-03 20:02 ` Dave Hansen
2013-06-03 20:02 ` [v5][PATCH 1/6] mm: swap: defer clearing of page_private() for swap cache pages Dave Hansen
2013-06-03 20:02 ` Dave Hansen
2013-07-14 23:47 ` Wanpeng Li
2013-07-14 23:47 ` Wanpeng Li
2013-06-03 20:02 ` [v5][PATCH 2/6] mm: swap: make 'struct page' and swp_entry_t variants of swapcache_free() Dave Hansen
2013-06-03 20:02 ` Dave Hansen
2013-07-14 23:48 ` Wanpeng Li
2013-07-14 23:48 ` Wanpeng Li
2013-06-03 20:02 ` [v5][PATCH 3/6] mm: vmscan: break up __remove_mapping() Dave Hansen
2013-06-03 20:02 ` Dave Hansen
2013-07-14 23:49 ` Wanpeng Li
2013-07-14 23:49 ` Wanpeng Li
2013-06-03 20:02 ` [v5][PATCH 4/6] mm: vmscan: break out mapping "freepage" code Dave Hansen
2013-06-03 20:02 ` Dave Hansen
2013-07-14 23:49 ` Wanpeng Li
2013-07-14 23:49 ` Wanpeng Li
2013-06-03 20:02 ` [v5][PATCH 5/6] mm: vmscan: batch shrink_page_list() locking operations Dave Hansen
2013-06-03 20:02 ` Dave Hansen
2013-06-04 1:17 ` Hillf Danton
2013-06-04 1:17 ` Hillf Danton
2013-06-04 5:07 ` Minchan Kim
2013-06-04 5:07 ` Minchan Kim
2013-06-04 15:22 ` Dave Hansen
2013-06-04 15:22 ` Dave Hansen
2013-06-05 7:28 ` Hillf Danton
2013-06-05 7:28 ` Hillf Danton
2013-06-05 7:57 ` Minchan Kim
2013-06-05 7:57 ` Minchan Kim
2013-06-05 14:24 ` Dave Hansen
2013-06-05 14:24 ` Dave Hansen
2013-06-04 5:01 ` Minchan Kim
2013-06-04 5:01 ` Minchan Kim
2013-06-04 6:02 ` Minchan Kim
2013-06-04 6:02 ` Minchan Kim
2013-06-04 15:29 ` Dave Hansen
2013-06-04 15:29 ` Dave Hansen
2013-06-04 23:32 ` Minchan Kim
2013-06-04 23:32 ` Minchan Kim
2013-06-04 6:10 ` Dave Hansen
2013-06-04 6:10 ` Dave Hansen
2013-06-04 6:59 ` Minchan Kim
2013-06-04 6:59 ` Minchan Kim
2013-07-14 23:50 ` Wanpeng Li
2013-07-14 23:50 ` Wanpeng Li
2013-06-03 20:02 ` [v5][PATCH 6/6] mm: vmscan: drain batch list during long operations Dave Hansen
2013-06-03 20:02 ` Dave Hansen
2013-06-04 6:05 ` Minchan Kim
2013-06-04 6:05 ` Minchan Kim
2013-06-04 15:24 ` Dave Hansen
2013-06-04 15:24 ` Dave Hansen
2013-06-04 23:23 ` Minchan Kim
2013-06-04 23:23 ` Minchan Kim
2013-06-04 23:31 ` Dave Hansen [this message]
2013-06-04 23:31 ` Dave Hansen
2013-06-04 23:36 ` Minchan Kim
2013-06-04 23:36 ` Minchan Kim
2013-06-04 23:37 ` Minchan Kim
2013-06-04 23:37 ` Minchan Kim
2013-07-14 23:51 ` Wanpeng Li
2013-07-14 23:51 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AE78C3.1040500@sr71.net \
--to=dave@sr71.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.