From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] cpuidle: move ARCH_NEEDS_CPU_IDLE_COUPLED Kconfig option
Date: Wed, 05 Jun 2013 14:50:44 +0200 [thread overview]
Message-ID: <51AF3424.5060200@linaro.org> (raw)
In-Reply-To: <1460854.rT4b7LefMM@wuerfel>
On 06/05/2013 02:38 PM, Arnd Bergmann wrote:
> There is no reason why ARCH_NEEDS_CPU_IDLE_COUPLED needs to be
> hidden inside of "if CPU_IDLE", since it is a silent option.
> Moving it outside lets platforms select this symbol unconditionally,
> which avoid a warning from the ARM omap2plus_defconfig build:
>
> warning: (ARCH_OMAP4 && ARCH_TEGRA_2x_SOC) selects
> ARCH_NEEDS_CPU_IDLE_COUPLED which has unmet direct
> dependencies (CPU_IDLE)
IMHO, this option depends on CPU_IDLE and thus must be kept inside the
CPU_IDLE menuconfig.
The warning raised here is because this option is selected by the arch
Kconfig without checking if CPU_IDLE is set or not.
I am in favor to change the OMAP / TEGRA Kconfigs instead, in this way:
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index f49cd51..831e89e 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -83,7 +83,7 @@ config ARCH_OMAP4
depends on ARCH_OMAP2PLUS
depends on ARCH_MULTI_V7
select ARCH_HAS_OPP
- select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
+ select ARCH_NEEDS_CPU_IDLE_COUPLED if (SMP && CPU_IDLE)
select ARM_CPU_SUSPEND if PM
select ARM_ERRATA_720789
select ARM_GIC
diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
index 84d72fc..04c6221 100644
--- a/arch/arm/mach-tegra/Kconfig
+++ b/arch/arm/mach-tegra/Kconfig
@@ -23,7 +23,7 @@ menu "NVIDIA Tegra options"
config ARCH_TEGRA_2x_SOC
bool "Enable support for Tegra20 family"
- select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
+ select ARCH_NEEDS_CPU_IDLE_COUPLED if (SMP && CPU_IDLE)
select ARM_ERRATA_720789
select ARM_ERRATA_754327 if SMP
select ARM_ERRATA_764369 if SMP
diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig
[ ... ]
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpuidle: move ARCH_NEEDS_CPU_IDLE_COUPLED Kconfig option
Date: Wed, 05 Jun 2013 14:50:44 +0200 [thread overview]
Message-ID: <51AF3424.5060200@linaro.org> (raw)
In-Reply-To: <1460854.rT4b7LefMM@wuerfel>
On 06/05/2013 02:38 PM, Arnd Bergmann wrote:
> There is no reason why ARCH_NEEDS_CPU_IDLE_COUPLED needs to be
> hidden inside of "if CPU_IDLE", since it is a silent option.
> Moving it outside lets platforms select this symbol unconditionally,
> which avoid a warning from the ARM omap2plus_defconfig build:
>
> warning: (ARCH_OMAP4 && ARCH_TEGRA_2x_SOC) selects
> ARCH_NEEDS_CPU_IDLE_COUPLED which has unmet direct
> dependencies (CPU_IDLE)
IMHO, this option depends on CPU_IDLE and thus must be kept inside the
CPU_IDLE menuconfig.
The warning raised here is because this option is selected by the arch
Kconfig without checking if CPU_IDLE is set or not.
I am in favor to change the OMAP / TEGRA Kconfigs instead, in this way:
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index f49cd51..831e89e 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -83,7 +83,7 @@ config ARCH_OMAP4
depends on ARCH_OMAP2PLUS
depends on ARCH_MULTI_V7
select ARCH_HAS_OPP
- select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
+ select ARCH_NEEDS_CPU_IDLE_COUPLED if (SMP && CPU_IDLE)
select ARM_CPU_SUSPEND if PM
select ARM_ERRATA_720789
select ARM_GIC
diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
index 84d72fc..04c6221 100644
--- a/arch/arm/mach-tegra/Kconfig
+++ b/arch/arm/mach-tegra/Kconfig
@@ -23,7 +23,7 @@ menu "NVIDIA Tegra options"
config ARCH_TEGRA_2x_SOC
bool "Enable support for Tegra20 family"
- select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
+ select ARCH_NEEDS_CPU_IDLE_COUPLED if (SMP && CPU_IDLE)
select ARM_ERRATA_720789
select ARM_ERRATA_754327 if SMP
select ARM_ERRATA_764369 if SMP
diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig
[ ... ]
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2013-06-05 12:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 12:38 [PATCH] cpuidle: move ARCH_NEEDS_CPU_IDLE_COUPLED Kconfig option Arnd Bergmann
2013-06-05 12:38 ` Arnd Bergmann
2013-06-05 12:50 ` Daniel Lezcano [this message]
2013-06-05 12:50 ` Daniel Lezcano
2013-06-05 20:36 ` Rafael J. Wysocki
2013-06-05 20:36 ` Rafael J. Wysocki
2013-06-07 10:53 ` Arnd Bergmann
2013-06-07 10:53 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AF3424.5060200@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.