From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Heiko Stübner" <heiko@sntech.de>,
"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"John Stultz" <john.stultz@linaro.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Mike Turquette" <mturquette@linaro.org>,
"Seungwon Jeon" <tgih.jun@samsung.com>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
"Chris Ball" <cjb@laptop.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"Grant Likely" <grant.likely@linaro.org>,
"Rob Herring" <rob.herring@calxeda.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"Russell King" <linux@arm.linux.org.uk>,
"Arnd Bergmann" <arnd@arndb.de>,
"Olof Johansson" <olof@lixom.net>
Subject: Re: [PATCH 07/10] pinctrl: add pinctrl driver for Rockchip SoCs
Date: Wed, 05 Jun 2013 11:18:49 -0600 [thread overview]
Message-ID: <51AF72F9.3060307@wwwdotorg.org> (raw)
In-Reply-To: <CACRpkdZty-TszfBTOab4_PUi8dy5DYim=wNERv=pyqC3HNuT4w@mail.gmail.com>
On 06/05/2013 01:01 AM, Linus Walleij wrote:
> On Tue, Jun 4, 2013 at 2:05 PM, Heiko Stübner <heiko@sntech.de> wrote:
...
>> The only problem is the pull stuff mentioned above that is either pull up or
>> down without the driver having knowledge about it. And generic_pinconf only
>> knows about them separately right now.
>
> Create a separate patch adding PIN_CONFIG_BIAS_PULL_AUTO
> to include/linux/pinctrl/pinconf-generic.h, don't forget the
> kerneldoc, and patching drivers/pinctrl/pinconf-generic.c.
"AUTO" sounds really rather generic. Based on just the word "AUTO", I
have no idea if it's a HW- or SW-supplied default, or what the algorithm
is for determining the automatically selected value. Perhaps
s/AUTO/PIN_DEFAULT/ or something like that?
While the concept is simple enough, it's unusual enough that such a
patch would hopefully have a comment containing a full explanation of
exactly what this option means.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/10] pinctrl: add pinctrl driver for Rockchip SoCs
Date: Wed, 05 Jun 2013 11:18:49 -0600 [thread overview]
Message-ID: <51AF72F9.3060307@wwwdotorg.org> (raw)
In-Reply-To: <CACRpkdZty-TszfBTOab4_PUi8dy5DYim=wNERv=pyqC3HNuT4w@mail.gmail.com>
On 06/05/2013 01:01 AM, Linus Walleij wrote:
> On Tue, Jun 4, 2013 at 2:05 PM, Heiko St?bner <heiko@sntech.de> wrote:
...
>> The only problem is the pull stuff mentioned above that is either pull up or
>> down without the driver having knowledge about it. And generic_pinconf only
>> knows about them separately right now.
>
> Create a separate patch adding PIN_CONFIG_BIAS_PULL_AUTO
> to include/linux/pinctrl/pinconf-generic.h, don't forget the
> kerneldoc, and patching drivers/pinctrl/pinconf-generic.c.
"AUTO" sounds really rather generic. Based on just the word "AUTO", I
have no idea if it's a HW- or SW-supplied default, or what the algorithm
is for determining the automatically selected value. Perhaps
s/AUTO/PIN_DEFAULT/ or something like that?
While the concept is simple enough, it's unusual enough that such a
patch would hopefully have a comment containing a full explanation of
exactly what this option means.
next prev parent reply other threads:[~2013-06-05 17:18 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-02 22:55 arm: add basic support for Rockchip Cortex-A9 SoCs Heiko Stübner
2013-06-02 22:55 ` Heiko Stübner
2013-06-02 22:55 ` Heiko Stübner
[not found] ` <201306030055.15413.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-06-02 22:56 ` [PATCH 01/10] clocksource: dw_apb_timer_of: use the clocksource as sched clock if necessary Heiko Stübner
2013-06-02 22:56 ` Heiko Stübner
2013-06-02 22:56 ` Heiko Stübner
2013-06-04 6:34 ` Linus Walleij
2013-06-04 6:34 ` Linus Walleij
2013-06-04 8:29 ` Heiko Stübner
2013-06-04 8:29 ` Heiko Stübner
2013-06-04 9:43 ` Linus Walleij
2013-06-04 9:43 ` Linus Walleij
2013-06-02 22:56 ` [PATCH 02/10] clocksource: dw_apb_timer_of: add clock-handling Heiko Stübner
2013-06-02 22:56 ` Heiko Stübner
2013-06-02 22:56 ` Heiko Stübner
2013-06-03 3:22 ` Baruch Siach
2013-06-03 3:22 ` Baruch Siach
2013-06-03 7:51 ` Heiko Stübner
2013-06-03 7:51 ` Heiko Stübner
2013-06-03 7:51 ` Heiko Stübner
2013-06-02 22:57 ` [PATCH 03/10] clk: flag to use upper half of the register as change indicator Heiko Stübner
2013-06-02 22:57 ` Heiko Stübner
2013-06-02 22:57 ` Heiko Stübner
2013-06-02 22:57 ` [PATCH 04/10] clk: divider: add flag to limit possible dividers to even numbers Heiko Stübner
2013-06-02 22:57 ` Heiko Stübner
2013-06-02 22:57 ` Heiko Stübner
2013-06-02 22:58 ` [PATCH 05/10] mmc: dw_mmc-pltfm: remove static from dw_mci_pltfm_remove Heiko Stübner
2013-06-02 22:58 ` Heiko Stübner
2013-06-02 22:58 ` Heiko Stübner
2013-06-04 3:59 ` Jaehoon Chung
2013-06-04 3:59 ` Jaehoon Chung
[not found] ` <201306030058.27184.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-06-05 14:00 ` Seungwon Jeon
2013-06-05 14:00 ` Seungwon Jeon
2013-06-05 14:00 ` Seungwon Jeon
2013-06-02 22:59 ` [PATCH 06/10] mmc: dw_mmc-pltfm: add Rockchip variant Heiko Stübner
2013-06-02 22:59 ` Heiko Stübner
2013-06-02 22:59 ` Heiko Stübner
2013-06-04 4:06 ` Jaehoon Chung
2013-06-04 4:06 ` Jaehoon Chung
2013-06-04 8:43 ` Heiko Stübner
2013-06-04 8:43 ` Heiko Stübner
[not found] ` <201306030059.03783.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-06-05 14:00 ` Seungwon Jeon
2013-06-05 14:00 ` Seungwon Jeon
2013-06-05 14:00 ` Seungwon Jeon
2013-06-05 14:11 ` Heiko Stübner
2013-06-05 14:11 ` Heiko Stübner
2013-06-06 20:01 ` Andy Shevchenko
2013-06-06 20:01 ` Andy Shevchenko
2013-06-02 22:59 ` [PATCH 07/10] pinctrl: add pinctrl driver for Rockchip SoCs Heiko Stübner
2013-06-02 22:59 ` Heiko Stübner
2013-06-02 22:59 ` Heiko Stübner
2013-06-04 7:08 ` Linus Walleij
2013-06-04 7:08 ` Linus Walleij
2013-06-04 12:05 ` Heiko Stübner
2013-06-04 12:05 ` Heiko Stübner
2013-06-05 7:01 ` Linus Walleij
2013-06-05 7:01 ` Linus Walleij
2013-06-05 17:18 ` Stephen Warren [this message]
2013-06-05 17:18 ` Stephen Warren
[not found] ` <51AF72F9.3060307-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-05 18:50 ` Heiko Stübner
2013-06-05 18:50 ` Heiko Stübner
2013-06-05 18:50 ` Heiko Stübner
2013-06-02 23:00 ` [PATCH 08/10] clk: add basic Rockchip rk3066a clock support Heiko Stübner
2013-06-02 23:00 ` Heiko Stübner
2013-06-03 3:27 ` Olof Johansson
2013-06-03 3:27 ` Olof Johansson
[not found] ` <20130603032711.GA3379-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2013-06-03 7:52 ` Heiko Stübner
2013-06-03 7:52 ` Heiko Stübner
2013-06-03 7:52 ` Heiko Stübner
2013-06-02 23:01 ` [PATCH 09/10] arm: add debug uarts for rockchip rk29xx and rk3xxx series Heiko Stübner
2013-06-02 23:01 ` Heiko Stübner
2013-06-03 2:08 ` Arnd Bergmann
2013-06-03 2:08 ` Arnd Bergmann
2013-06-03 7:54 ` Heiko Stübner
2013-06-03 7:54 ` Heiko Stübner
2013-06-02 23:02 ` [PATCH 10/10] arm: add basic support for Rockchip RK3066a boards Heiko Stübner
2013-06-02 23:02 ` Heiko Stübner
2013-06-03 2:15 ` Arnd Bergmann
2013-06-03 2:15 ` Arnd Bergmann
2013-06-03 8:23 ` Heiko Stübner
2013-06-03 8:23 ` Heiko Stübner
[not found] ` <201306031023.49364.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-06-03 9:22 ` Arnd Bergmann
2013-06-03 9:22 ` Arnd Bergmann
2013-06-03 9:22 ` Arnd Bergmann
2013-06-03 9:46 ` Heiko Stübner
2013-06-03 9:46 ` Heiko Stübner
2013-06-03 10:26 ` Arnd Bergmann
2013-06-03 10:26 ` Arnd Bergmann
2013-06-03 12:15 ` [RFC] dw_apb_timer_of: use clocksource_of_init Heiko Stübner
2013-06-03 12:27 ` Rob Herring
2013-06-03 12:27 ` Rob Herring
2013-06-03 13:20 ` Arnd Bergmann
2013-06-03 13:20 ` Arnd Bergmann
2013-06-05 7:11 ` [PATCH 10/10] arm: add basic support for Rockchip RK3066a boards Thomas Petazzoni
2013-06-05 7:11 ` Thomas Petazzoni
2013-06-05 21:45 ` Maxime Ripard
2013-06-05 21:45 ` Maxime Ripard
2013-06-03 2:07 ` arm: add basic support for Rockchip Cortex-A9 SoCs Arnd Bergmann
2013-06-03 2:07 ` Arnd Bergmann
2013-06-03 2:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AF72F9.3060307@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=jh80.chung@samsung.com \
--cc=john.stultz@linaro.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=tgih.jun@samsung.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.