From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Christoph Lameter <cl@gentwo.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-mm@kvack.org, Mel Gorman <mgorman@suse.de>,
Rik van Riel <riel@redhat.com>, Hugh Dickins <hughd@google.com>,
Richard Davies <richard@arachsys.com>,
Shaohua Li <shli@kernel.org>, Rafael Aquini <aquini@redhat.com>
Subject: Re: [PATCH 1/7] mm: remove ZONE_RECLAIM_LOCKED
Date: Wed, 05 Jun 2013 17:03:02 -0400 [thread overview]
Message-ID: <51AFA786.1040608@gmail.com> (raw)
In-Reply-To: <0000013f161c3f42-14ae4d9d-fd85-47dd-ba80-896e1e84a6fe-000000@email.amazonses.com>
(6/5/13 4:51 PM), Christoph Lameter wrote:
> On Wed, 5 Jun 2013, KOSAKI Motohiro wrote:
>
>> (6/5/13 11:10 AM), Andrea Arcangeli wrote:
>>> Zone reclaim locked breaks zone_reclaim_mode=1. If more than one
>>> thread allocates memory at the same time, it forces a premature
>>> allocation into remote NUMA nodes even when there's plenty of clean
>>> cache to reclaim in the local nodes.
>>>
>>> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
>>
>> You should Christoph Lameter who make this lock. I've CCed. I couldn't
>> find any problem in this removing. But I also didn't find a reason why
>> this lock is needed.
>
> There was early on an issue with multiple zone reclaims from
> different processors causing an extreme slowdown and the system would go
> OOM. The flag was used to enforce that only a single zone reclaim pass was
> occurring at one time on a zone. This minimized contention and avoided
> the failure.
OK. I've convinced now we can removed because sc->nr_to_reclaim protect us form
this issue.
Thank you, guys.
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-06-05 21:02 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 15:10 [PATCH 0/7] RFC: adding compaction to zone_reclaim_mode > 0 Andrea Arcangeli
2013-06-05 15:10 ` [PATCH 1/7] mm: remove ZONE_RECLAIM_LOCKED Andrea Arcangeli
2013-06-05 19:23 ` Rik van Riel
2013-06-05 20:37 ` KOSAKI Motohiro
2013-06-05 20:51 ` Christoph Lameter
2013-06-05 21:03 ` KOSAKI Motohiro [this message]
2013-06-06 14:15 ` Christoph Lameter
2013-06-06 17:17 ` KOSAKI Motohiro
2013-06-06 18:16 ` Christoph Lameter
2013-06-05 21:33 ` Rafael Aquini
2013-06-06 9:04 ` Mel Gorman
2013-06-06 17:37 ` Rik van Riel
2013-06-14 16:16 ` Rik van Riel
2013-06-17 9:30 ` Mel Gorman
2013-06-17 18:12 ` Rik van Riel
2013-06-26 20:10 ` Andrea Arcangeli
2013-06-05 15:10 ` [PATCH 2/7] mm: compaction: scan all memory with /proc/sys/vm/compact_memory Andrea Arcangeli
2013-06-05 19:34 ` Rik van Riel
2013-06-05 21:39 ` Rafael Aquini
2013-06-06 9:05 ` Mel Gorman
2013-06-05 15:10 ` [PATCH 3/7] mm: compaction: don't depend on kswapd to invoke reset_isolation_suitable Andrea Arcangeli
2013-06-05 19:49 ` Rik van Riel
2013-06-26 20:38 ` Andrea Arcangeli
2013-06-06 9:11 ` Mel Gorman
2013-06-26 20:48 ` Andrea Arcangeli
2013-06-06 12:47 ` Rafael Aquini
2013-06-05 15:10 ` [PATCH 4/7] mm: compaction: reset before initializing the scan cursors Andrea Arcangeli
2013-06-05 20:04 ` Rik van Riel
2013-06-06 9:14 ` Mel Gorman
2013-06-06 12:49 ` Rafael Aquini
2013-06-05 15:10 ` [PATCH 5/7] mm: compaction: increase the high order pages in the watermarks Andrea Arcangeli
2013-06-05 20:18 ` Rik van Riel
2013-06-28 22:14 ` Andrea Arcangeli
2013-06-06 9:19 ` Mel Gorman
2013-06-05 15:10 ` [PATCH 6/7] mm: compaction: export compact_zone_order() Andrea Arcangeli
2013-06-05 20:24 ` Rik van Riel
2013-06-05 15:10 ` [PATCH 7/7] mm: compaction: add compaction to zone_reclaim_mode Andrea Arcangeli
2013-06-05 22:21 ` Rik van Riel
2013-06-06 10:05 ` Mel Gorman
2013-07-11 16:02 ` Andrea Arcangeli
2013-07-12 12:26 ` Hush Bensen
2013-07-12 16:01 ` Andrea Arcangeli
2013-07-12 23:23 ` Hush Bensen
2013-07-15 9:16 ` Andrea Arcangeli
2013-07-12 23:57 ` Hush Bensen
2013-07-15 9:25 ` Andrea Arcangeli
2013-06-06 8:53 ` [PATCH 0/7] RFC: adding compaction to zone_reclaim_mode > 0 Mel Gorman
2013-06-06 10:09 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AFA786.1040608@gmail.com \
--to=kosaki.motohiro@gmail.com \
--cc=aarcange@redhat.com \
--cc=aquini@redhat.com \
--cc=cl@gentwo.org \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=richard@arachsys.com \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.