From: "Steven J. Hill" <Steven.Hill@imgtec.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: <linux-mips@linux-mips.org>
Subject: Re: [PATCH v6] MIPS: micromips: Fix improper definition of ISA exception bit.
Date: Wed, 5 Jun 2013 16:15:56 -0500 [thread overview]
Message-ID: <51AFAA8C.6080002@imgtec.com> (raw)
In-Reply-To: <51AFA540.5010207@gmail.com>
On 06/05/2013 03:53 PM, David Daney wrote:
>
> You can only manipulate this bit if you know microMIPS is supported. So
> I think you should either not touch it for the non-microMIPS case, or
> make the write conditional on the presence of microMIPS support in the CPU.
>
I decided to surround with SYS_SUPPORTS_MICROMIPS so the function could
be optimized out in v7 of the patch.
WARNING: multiple messages have this Message-ID (diff)
From: "Steven J. Hill" <Steven.Hill@imgtec.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH v6] MIPS: micromips: Fix improper definition of ISA exception bit.
Date: Wed, 5 Jun 2013 16:15:56 -0500 [thread overview]
Message-ID: <51AFAA8C.6080002@imgtec.com> (raw)
Message-ID: <20130605211556.mvNrHWGb3HAXtxILErBDc7AiMg1m5ocssZqBJQxmFG4@z> (raw)
In-Reply-To: <51AFA540.5010207@gmail.com>
On 06/05/2013 03:53 PM, David Daney wrote:
>
> You can only manipulate this bit if you know microMIPS is supported. So
> I think you should either not touch it for the non-microMIPS case, or
> make the write conditional on the presence of microMIPS support in the CPU.
>
I decided to surround with SYS_SUPPORTS_MICROMIPS so the function could
be optimized out in v7 of the patch.
next prev parent reply other threads:[~2013-06-05 21:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 19:49 [PATCH v6] MIPS: micromips: Fix improper definition of ISA exception bit Steven J. Hill
2013-06-05 20:01 ` Sergei Shtylyov
2013-06-05 21:07 ` David Daney
2013-06-05 21:30 ` Sergei Shtylyov
2013-06-05 20:53 ` David Daney
2013-06-05 21:15 ` Steven J. Hill [this message]
2013-06-05 21:15 ` Steven J. Hill
2013-06-05 21:23 ` Jonas Gorski
2013-06-05 21:27 ` David Daney
2013-06-05 21:36 ` Steven J. Hill
2013-06-05 21:36 ` Steven J. Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AFAA8C.6080002@imgtec.com \
--to=steven.hill@imgtec.com \
--cc=ddaney.cavm@gmail.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.