From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: shawn.guo@linaro.org, linux-can@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH 1/2] flexcan: Use a regulator to control the CAN transceiver
Date: Thu, 06 Jun 2013 07:21:33 +0200 [thread overview]
Message-ID: <51B01C5D.2050609@pengutronix.de> (raw)
In-Reply-To: <1370460445-15386-1-git-send-email-festevam@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 745 bytes --]
On 06/05/2013 09:27 PM, Fabio Estevam wrote:
> Instead of using a GPIO to turn on/off the CAN transceiver, it is better to
> use a regulator as some systems may use a PMIC to power the CAN transceiver.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Just a short note, as I'm not in the office today.
I like the idea of using an established subsystem for the
transceiver/phy. But I don't like the solution you suggested in patch 2.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2013-06-06 5:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 19:27 [PATCH 1/2] flexcan: Use a regulator to control the CAN transceiver Fabio Estevam
2013-06-05 19:27 ` [PATCH 2/2] flexcan: Enable/Disable the CAN regulator in probe/remove Fabio Estevam
2013-06-10 17:02 ` Marc Kleine-Budde
2013-06-10 19:05 ` Fabio Estevam
2013-06-10 20:39 ` Marc Kleine-Budde
2013-06-10 20:49 ` Fabio Estevam
2013-06-10 23:35 ` Marc Kleine-Budde
2013-06-06 5:21 ` Marc Kleine-Budde [this message]
2013-06-10 16:59 ` [PATCH 1/2] flexcan: Use a regulator to control the CAN transceiver Marc Kleine-Budde
2013-06-10 17:03 ` Fabio Estevam
2013-06-11 2:38 ` Fabio Estevam
2013-06-12 9:39 ` Marc Kleine-Budde
2013-06-12 11:42 ` Shawn Guo
2013-06-12 12:06 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B01C5D.2050609@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.