All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Fabio Estevam <festevam@gmail.com>,
	linux-can@vger.kernel.org,
	Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH 1/2] flexcan: Use a regulator to control the CAN transceiver
Date: Wed, 12 Jun 2013 14:06:19 +0200	[thread overview]
Message-ID: <51B8643B.1020507@pengutronix.de> (raw)
In-Reply-To: <20130612114159.GD13274@S2101-09.ap.freescale.net>

[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]

On 06/12/2013 01:42 PM, Shawn Guo wrote:
> On Wed, Jun 05, 2013 at 04:27:24PM -0300, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Instead of using a GPIO to turn on/off the CAN transceiver, it is better to
>> use a regulator as some systems may use a PMIC to power the CAN transceiver.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>>  .../devicetree/bindings/net/can/fsl-flexcan.txt    |  2 +
>>  arch/arm/boot/dts/imx28-evk.dts                    | 11 +++++
>>  arch/arm/mach-mxs/mach-mxs.c                       | 54 ++--------------------
> 
> Acked-by: Shawn Guo <shawn.guo@linaro.org>

Tnx, I (back) ported the patch to current net-next/master, resulting in
this diff between the patches.

        of_platform_populate(NULL, of_default_bus_match_table,
--                           mxs_auxdata_lookup, parent);
-+                           NULL, parent);
+-                           mxs_auxdata_lookup, NULL);
++                           NULL, NULL);

Hope it's alright to keep your Acked-by. I will post the resulting patch
set soon, but I want to test it on real hardware next Monday.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

      reply	other threads:[~2013-06-12 12:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05 19:27 [PATCH 1/2] flexcan: Use a regulator to control the CAN transceiver Fabio Estevam
2013-06-05 19:27 ` [PATCH 2/2] flexcan: Enable/Disable the CAN regulator in probe/remove Fabio Estevam
2013-06-10 17:02   ` Marc Kleine-Budde
2013-06-10 19:05     ` Fabio Estevam
2013-06-10 20:39       ` Marc Kleine-Budde
2013-06-10 20:49         ` Fabio Estevam
2013-06-10 23:35           ` Marc Kleine-Budde
2013-06-06  5:21 ` [PATCH 1/2] flexcan: Use a regulator to control the CAN transceiver Marc Kleine-Budde
2013-06-10 16:59 ` Marc Kleine-Budde
2013-06-10 17:03   ` Fabio Estevam
2013-06-11  2:38   ` Fabio Estevam
2013-06-12  9:39     ` Marc Kleine-Budde
2013-06-12 11:42 ` Shawn Guo
2013-06-12 12:06   ` Marc Kleine-Budde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B8643B.1020507@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=linux-can@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.