From: "Arend van Spriel" <arend@broadcom.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Brett Rudley <brudley@broadcom.com>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
Hante Meuleman <meuleman@broadcom.com>,
"John W. Linville" <linville@tuxdriver.com>,
Pieter-Paul Giesberts <pieterpg@broadcom.com>,
Piotr Haber <phaber@broadcom.com>,
linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] brcmfmac: move dereference under check for NULL
Date: Thu, 06 Jun 2013 11:46:11 +0000 [thread overview]
Message-ID: <51B07683.2030408@broadcom.com> (raw)
In-Reply-To: <20130606105556.GD12953@debian>
On 06/06/2013 12:55 PM, Dan Carpenter wrote:
> skb_pull() dereferences the skb parameter.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Hi Dan,
Just missed that. This code fragment was resubmitted just minutes ago. I
will rework the patch to incorporate this change.
Regards,
Arend
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
> index ea37bd4..c35296f 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
> @@ -861,9 +861,9 @@ static bool brcmf_fws_tim_update(struct brcmf_fws_info *fws,
> BRCMF_FWS_TYPE_PENDING_TRAFFIC_BMP_LEN + 2 +
> 4 + fws->drvr->hdrlen;
> skb = brcmu_pkt_buf_get_skb(len);
> - skb_pull(skb, len);
> if (skb = NULL)
> return false;
> + skb_pull(skb, len);
> skcb = brcmf_skbcb(skb);
> skcb->mac = entry;
> skcb->state = BRCMF_FWS_SKBSTATE_TIM;
>
WARNING: multiple messages have this Message-ID (diff)
From: "Arend van Spriel" <arend@broadcom.com>
To: "Dan Carpenter" <dan.carpenter@oracle.com>
Cc: "Brett Rudley" <brudley@broadcom.com>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
"Hante Meuleman" <meuleman@broadcom.com>,
"John W. Linville" <linville@tuxdriver.com>,
"Pieter-Paul Giesberts" <pieterpg@broadcom.com>,
"Piotr Haber" <phaber@broadcom.com>,
linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] brcmfmac: move dereference under check for NULL
Date: Thu, 6 Jun 2013 13:46:11 +0200 [thread overview]
Message-ID: <51B07683.2030408@broadcom.com> (raw)
In-Reply-To: <20130606105556.GD12953@debian>
On 06/06/2013 12:55 PM, Dan Carpenter wrote:
> skb_pull() dereferences the skb parameter.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Hi Dan,
Just missed that. This code fragment was resubmitted just minutes ago. I
will rework the patch to incorporate this change.
Regards,
Arend
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
> index ea37bd4..c35296f 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
> @@ -861,9 +861,9 @@ static bool brcmf_fws_tim_update(struct brcmf_fws_info *fws,
> BRCMF_FWS_TYPE_PENDING_TRAFFIC_BMP_LEN + 2 +
> 4 + fws->drvr->hdrlen;
> skb = brcmu_pkt_buf_get_skb(len);
> - skb_pull(skb, len);
> if (skb == NULL)
> return false;
> + skb_pull(skb, len);
> skcb = brcmf_skbcb(skb);
> skcb->mac = entry;
> skcb->state = BRCMF_FWS_SKBSTATE_TIM;
>
next prev parent reply other threads:[~2013-06-06 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 10:55 [patch] brcmfmac: move dereference under check for NULL Dan Carpenter
2013-06-06 10:55 ` Dan Carpenter
2013-06-06 11:46 ` Arend van Spriel [this message]
2013-06-06 11:46 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B07683.2030408@broadcom.com \
--to=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=frankyl@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=meuleman@broadcom.com \
--cc=phaber@broadcom.com \
--cc=pieterpg@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.