From: "Andreas Färber" <afaerber@suse.de>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 5/5] trace-events: Fix up source file comments
Date: Fri, 07 Jun 2013 15:43:43 +0200 [thread overview]
Message-ID: <51B1E38F.70904@suse.de> (raw)
In-Reply-To: <1370602761-3566-6-git-send-email-armbru@redhat.com>
Am 07.06.2013 12:59, schrieb Markus Armbruster:
> They're all wrong since (at least) Paolo's big source tree
> reorganization. Need to shuffle some event declarations around to
> keep them under the correct source file comment.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> trace-events | 162 ++++++++++++++++++++++++++++++++---------------------------
> 1 file changed, 87 insertions(+), 75 deletions(-)
>
> diff --git a/trace-events b/trace-events
> index e12d376..d95e903 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -25,18 +25,14 @@
> #
> # The <format-string> should be a sprintf()-compatible format string.
>
> -# qemu-malloc.c
> -g_malloc(size_t size, void *ptr) "size %zu ptr %p"
> -g_realloc(void *ptr, size_t size, void *newptr) "ptr %p size %zu newptr %p"
> -g_free(void *ptr) "ptr %p"
> -
> -# osdep.c
> +# util/oslib-win32.c
> +# util/oslib-posix.c
[snip]
Thanks for taking time for this cleanup! I noticed before but haven't
found the time myself so far. ;)
If someone else feels like cleaning up, there's also quite a number of
header files which annotate prototypes with now wrong source files.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-06-07 13:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 10:59 [Qemu-devel] [PATCH 0/5] Trace fixes Markus Armbruster
2013-06-07 10:59 ` [Qemu-devel] [PATCH 1/5] cleanup-trace-events.pl: New Markus Armbruster
2013-06-07 10:59 ` [Qemu-devel] [PATCH 2/5] slavio_misc: Fix slavio_led_mem_readw/_writew tracepoints Markus Armbruster
2013-06-07 10:59 ` [Qemu-devel] [PATCH 3/5] milkymist-minimac2: Fix minimac2_read/_write tracepoints Markus Armbruster
2013-06-07 10:59 ` [Qemu-devel] [PATCH 4/5] trace-events: Drop unused events Markus Armbruster
2013-06-07 10:59 ` [Qemu-devel] [PATCH 5/5] trace-events: Fix up source file comments Markus Armbruster
2013-06-07 13:43 ` Andreas Färber [this message]
2013-06-10 11:29 ` [Qemu-devel] [PATCH 0/5] Trace fixes Stefan Hajnoczi
2013-06-10 11:30 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B1E38F.70904@suse.de \
--to=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.