From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Benoit Cousson <b-cousson-l0cyMroinI0@public.gmane.org>
Cc: swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
J Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH] ARM: dts: add dtsi for palmas
Date: Fri, 07 Jun 2013 13:22:58 -0600 [thread overview]
Message-ID: <51B23312.8000402@wwwdotorg.org> (raw)
In-Reply-To: <51B1D1A9.40702-l0cyMroinI0@public.gmane.org>
On 06/07/2013 06:27 AM, Benoit Cousson wrote:
> Hi Keerthy,
>
> On 06/07/2013 01:28 PM, J Keerthy wrote:
>> Adds palmas mfd and palmas regulator nodes. This is
>> based on the patch series:
>>
>> http://www.mail-archive.com/linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg89957.html
>>
>> The device tree nodes are based on:
>> https://lkml.org/lkml/2013/6/6/25
...
>> diff --git a/arch/arm/boot/dts/palmas.dtsi b/arch/arm/boot/dts/palmas.dtsi
...
>> +&palmas {
>> + compatible = "ti,palmas";
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>
> The I2C address should be there as well. We used to put it in the board
> file, but this is really an I2C device specific information and not
> board specific in that case.
I thought the I2C address was variable depending on OTP settings, and
hence the I2C address is board-specific; depending on which variant of
the PMIC was stuffed onto the board?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Benoit Cousson <b-cousson@ti.com>
Cc: J Keerthy <j-keerthy@ti.com>,
devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, ldewangan@nvidia.com,
grant.likely@secretlab.ca, swarren@nvidia.com,
sameo@linux.intel.com, gg@slimlogic.co.uk, lee.jones@linaro.org
Subject: Re: [PATCH] ARM: dts: add dtsi for palmas
Date: Fri, 07 Jun 2013 13:22:58 -0600 [thread overview]
Message-ID: <51B23312.8000402@wwwdotorg.org> (raw)
In-Reply-To: <51B1D1A9.40702@ti.com>
On 06/07/2013 06:27 AM, Benoit Cousson wrote:
> Hi Keerthy,
>
> On 06/07/2013 01:28 PM, J Keerthy wrote:
>> Adds palmas mfd and palmas regulator nodes. This is
>> based on the patch series:
>>
>> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg89957.html
>>
>> The device tree nodes are based on:
>> https://lkml.org/lkml/2013/6/6/25
...
>> diff --git a/arch/arm/boot/dts/palmas.dtsi b/arch/arm/boot/dts/palmas.dtsi
...
>> +&palmas {
>> + compatible = "ti,palmas";
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>
> The I2C address should be there as well. We used to put it in the board
> file, but this is really an I2C device specific information and not
> board specific in that case.
I thought the I2C address was variable depending on OTP settings, and
hence the I2C address is board-specific; depending on which variant of
the PMIC was stuffed onto the board?
next prev parent reply other threads:[~2013-06-07 19:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 11:28 [PATCH] ARM: dts: add dtsi for palmas J Keerthy
2013-06-07 11:28 ` J Keerthy
[not found] ` <1370604504-32310-1-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2013-06-07 12:27 ` Benoit Cousson
2013-06-07 12:27 ` Benoit Cousson
2013-06-07 12:32 ` J, KEERTHY
[not found] ` <51B1D1A9.40702-l0cyMroinI0@public.gmane.org>
2013-06-07 19:22 ` Stephen Warren [this message]
2013-06-07 19:22 ` Stephen Warren
2013-06-07 19:56 ` Stephen Warren
2013-06-10 4:03 ` J, KEERTHY
2013-06-10 8:04 ` Lee Jones
[not found] ` <DC88CAD03C0052499C1907B327FC63229EAA39-yXqyApvAXouIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2013-06-10 9:29 ` Benoit Cousson
2013-06-10 9:29 ` Benoit Cousson
2013-06-10 10:17 ` J, KEERTHY
2013-06-10 16:21 ` Stephen Warren
2013-06-10 16:22 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B23312.8000402@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=b-cousson-l0cyMroinI0@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org \
--cc=j-keerthy-l0cyMroinI0@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.