All of lore.kernel.org
 help / color / mirror / Atom feed
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: Arm sub architectures missing clk_round_rate()
Date: Sat, 08 Jun 2013 09:57:17 +0100	[thread overview]
Message-ID: <51B2F1ED.2090801@kernel.org> (raw)

At least one Arm subarch (pxa) does no provide an implementation of this
function.  As far as I can see there is no way for a driver wishing to use
it to detect it's absence.  This is marked in clk.h as being optional
for 'Machine Class support'. Obvious solutions to this are:

1) It is effectively only usable by platform specific drivers as no
   more generic driver can know it is available.  Perhaps even a stub that
   returns an appropriate error would be acceptable.

2) It is not as optional as the header implies and should always be implemented
   if the rest of the clk framework is.

3) There should be some means of detecting its absense so that drivers can
   be dependant on its presene.

Which is the correct one?

This issue came up as a result of the thread
http://marc.info/?l=linux-iio&m=137026653516438&w=2
[PATCH RESEND V2 3/4] iio: frequency: adf4350: Add support for clock consumer framework
on linux-iio at vger.kernel.org


Thanks,

Jonathan

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	Lars-Peter Clausen <lars@metafoo.de>
Subject: Arm sub architectures missing clk_round_rate()
Date: Sat, 08 Jun 2013 09:57:17 +0100	[thread overview]
Message-ID: <51B2F1ED.2090801@kernel.org> (raw)

At least one Arm subarch (pxa) does no provide an implementation of this
function.  As far as I can see there is no way for a driver wishing to use
it to detect it's absence.  This is marked in clk.h as being optional
for 'Machine Class support'. Obvious solutions to this are:

1) It is effectively only usable by platform specific drivers as no
   more generic driver can know it is available.  Perhaps even a stub that
   returns an appropriate error would be acceptable.

2) It is not as optional as the header implies and should always be implemented
   if the rest of the clk framework is.

3) There should be some means of detecting its absense so that drivers can
   be dependant on its presene.

Which is the correct one?

This issue came up as a result of the thread
http://marc.info/?l=linux-iio&m=137026653516438&w=2
[PATCH RESEND V2 3/4] iio: frequency: adf4350: Add support for clock consumer framework
on linux-iio@vger.kernel.org


Thanks,

Jonathan

             reply	other threads:[~2013-06-08  8:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-08  8:57 Jonathan Cameron [this message]
2013-06-08  8:57 ` Arm sub architectures missing clk_round_rate() Jonathan Cameron
2013-06-08  9:21 ` Russell King - ARM Linux
2013-06-08  9:21   ` Russell King - ARM Linux
2013-06-08  9:32   ` Jonathan Cameron
2013-06-08  9:32     ` Jonathan Cameron
2013-06-08 10:14   ` Haojian Zhuang
2013-06-08 10:14     ` Haojian Zhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B2F1ED.2090801@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.