All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	"Peter Crosthwaite" <peter.crosthwaite@petalogix.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] ioport/memory: check that both .read and .write callbacks are defined
Date: Mon, 10 Jun 2013 07:27:40 +0200	[thread overview]
Message-ID: <51B563CC.5040907@redhat.com> (raw)
In-Reply-To: <51B2E26F.8030106@msgid.tls.msk.ru>

  Hi,

> Maybe instead (or in addition to), we should provide a dummy
> read or write functions -- instead of fixing each such occurence
> to use its own dummy function

Makes sense, especially for write where we can just ignore what the
guest attempts to write.  Not sure we can have a generic handler for
reads.  Maybe two, one which returns 0xff and one which returns 0x00.

cheers,
  Gerd




WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	"Peter Crosthwaite" <peter.crosthwaite@petalogix.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] ioport/memory: check that both .read and .write callbacks are defined
Date: Mon, 10 Jun 2013 07:27:40 +0200	[thread overview]
Message-ID: <51B563CC.5040907@redhat.com> (raw)
In-Reply-To: <51B2E26F.8030106@msgid.tls.msk.ru>

  Hi,

> Maybe instead (or in addition to), we should provide a dummy
> read or write functions -- instead of fixing each such occurence
> to use its own dummy function

Makes sense, especially for write where we can just ignore what the
guest attempts to write.  Not sure we can have a generic handler for
reads.  Maybe two, one which returns 0xff and one which returns 0x00.

cheers,
  Gerd

  reply	other threads:[~2013-06-10  5:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05 13:42 [Qemu-trivial] [PATCH] ioport/memory: check that both .read and .write callbacks are defined Hervé Poussineau
2013-06-05 13:42 ` [Qemu-devel] " Hervé Poussineau
2013-06-08  7:51 ` [Qemu-trivial] " Michael Tokarev
2013-06-08  7:51   ` [Qemu-devel] " Michael Tokarev
2013-06-10  5:27   ` Gerd Hoffmann [this message]
2013-06-10  5:27     ` Gerd Hoffmann
2013-06-10  9:14     ` Peter Crosthwaite
2013-06-10  9:14       ` [Qemu-devel] " Peter Crosthwaite
2013-06-10 17:06       ` Michael S. Tsirkin
2013-06-10 17:06         ` [Qemu-devel] " Michael S. Tsirkin
2013-06-10 22:30         ` [Qemu-trivial] [Qemu-devel] " Peter Crosthwaite
2013-06-10 22:30           ` [Qemu-devel] [Qemu-trivial] " Peter Crosthwaite
2013-06-10 22:53           ` [Qemu-trivial] [Qemu-devel] " Edgar E. Iglesias
2013-06-10 22:53             ` [Qemu-devel] [Qemu-trivial] " Edgar E. Iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B563CC.5040907@redhat.com \
    --to=kraxel@redhat.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=hpoussin@reactos.org \
    --cc=mjt@tls.msk.ru \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.crosthwaite@petalogix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.