* [PATCH] MIPS: include: mmu_context.h: Replace VIRTUALIZATION with KVM
@ 2013-06-10 11:42 ` Markos Chandras
0 siblings, 0 replies; 5+ messages in thread
From: Markos Chandras @ 2013-06-10 11:42 UTC (permalink / raw)
To: linux-mips; +Cc: Markos Chandras, Steven J. Hill
The kvm_* symbols are only available if KVM is selected.
Fixes the following linking problem on a randconfig:
arch/mips/built-in.o: In function `local_flush_tlb_mm':
(.text+0x18a94): undefined reference to `kvm_local_flush_tlb_all'
arch/mips/built-in.o: In function `local_flush_tlb_range':
(.text+0x18d0c): undefined reference to `kvm_local_flush_tlb_all'
kernel/built-in.o: In function `__schedule':
core.c:(.sched.text+0x2a00): undefined reference to `kvm_local_flush_tlb_all'
mm/built-in.o: In function `use_mm':
(.text+0x30214): undefined reference to `kvm_local_flush_tlb_all'
fs/built-in.o: In function `flush_old_exec':
(.text+0xf0a0): undefined reference to `kvm_local_flush_tlb_all'
make: *** [vmlinux] Error 1
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>
---
arch/mips/include/asm/mmu_context.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/mips/include/asm/mmu_context.h b/arch/mips/include/asm/mmu_context.h
index 8201160..ee5a93b 100644
--- a/arch/mips/include/asm/mmu_context.h
+++ b/arch/mips/include/asm/mmu_context.h
@@ -111,13 +111,15 @@ static inline void enter_lazy_tlb(struct mm_struct *mm, struct task_struct *tsk)
static inline void
get_new_mmu_context(struct mm_struct *mm, unsigned long cpu)
{
+#ifdef CONFIG_KVM
extern void kvm_local_flush_tlb_all(void);
+#endif
unsigned long asid = asid_cache(cpu);
if (! ((asid += ASID_INC) & ASID_MASK) ) {
if (cpu_has_vtag_icache)
flush_icache_all();
-#ifdef CONFIG_VIRTUALIZATION
+#ifdef CONFIG_KVM
kvm_local_flush_tlb_all(); /* start new asid cycle */
#else
local_flush_tlb_all(); /* start new asid cycle */
--
1.8.2.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] MIPS: include: mmu_context.h: Replace VIRTUALIZATION with KVM
@ 2013-06-10 11:42 ` Markos Chandras
0 siblings, 0 replies; 5+ messages in thread
From: Markos Chandras @ 2013-06-10 11:42 UTC (permalink / raw)
To: linux-mips; +Cc: Markos Chandras, Steven J. Hill
The kvm_* symbols are only available if KVM is selected.
Fixes the following linking problem on a randconfig:
arch/mips/built-in.o: In function `local_flush_tlb_mm':
(.text+0x18a94): undefined reference to `kvm_local_flush_tlb_all'
arch/mips/built-in.o: In function `local_flush_tlb_range':
(.text+0x18d0c): undefined reference to `kvm_local_flush_tlb_all'
kernel/built-in.o: In function `__schedule':
core.c:(.sched.text+0x2a00): undefined reference to `kvm_local_flush_tlb_all'
mm/built-in.o: In function `use_mm':
(.text+0x30214): undefined reference to `kvm_local_flush_tlb_all'
fs/built-in.o: In function `flush_old_exec':
(.text+0xf0a0): undefined reference to `kvm_local_flush_tlb_all'
make: *** [vmlinux] Error 1
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>
---
arch/mips/include/asm/mmu_context.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/mips/include/asm/mmu_context.h b/arch/mips/include/asm/mmu_context.h
index 8201160..ee5a93b 100644
--- a/arch/mips/include/asm/mmu_context.h
+++ b/arch/mips/include/asm/mmu_context.h
@@ -111,13 +111,15 @@ static inline void enter_lazy_tlb(struct mm_struct *mm, struct task_struct *tsk)
static inline void
get_new_mmu_context(struct mm_struct *mm, unsigned long cpu)
{
+#ifdef CONFIG_KVM
extern void kvm_local_flush_tlb_all(void);
+#endif
unsigned long asid = asid_cache(cpu);
if (! ((asid += ASID_INC) & ASID_MASK) ) {
if (cpu_has_vtag_icache)
flush_icache_all();
-#ifdef CONFIG_VIRTUALIZATION
+#ifdef CONFIG_KVM
kvm_local_flush_tlb_all(); /* start new asid cycle */
#else
local_flush_tlb_all(); /* start new asid cycle */
--
1.8.2.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] MIPS: include: mmu_context.h: Replace VIRTUALIZATION with KVM
2013-06-10 11:42 ` Markos Chandras
(?)
@ 2013-06-10 11:49 ` Sergei Shtylyov
2013-06-10 12:51 ` Markos Chandras
-1 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2013-06-10 11:49 UTC (permalink / raw)
To: Markos Chandras; +Cc: linux-mips, Steven J. Hill
hello.
On 10-06-2013 15:42, Markos Chandras wrote:
> The kvm_* symbols are only available if KVM is selected.
> Fixes the following linking problem on a randconfig:
> arch/mips/built-in.o: In function `local_flush_tlb_mm':
> (.text+0x18a94): undefined reference to `kvm_local_flush_tlb_all'
> arch/mips/built-in.o: In function `local_flush_tlb_range':
> (.text+0x18d0c): undefined reference to `kvm_local_flush_tlb_all'
> kernel/built-in.o: In function `__schedule':
> core.c:(.sched.text+0x2a00): undefined reference to `kvm_local_flush_tlb_all'
> mm/built-in.o: In function `use_mm':
> (.text+0x30214): undefined reference to `kvm_local_flush_tlb_all'
> fs/built-in.o: In function `flush_old_exec':
> (.text+0xf0a0): undefined reference to `kvm_local_flush_tlb_all'
> make: *** [vmlinux] Error 1
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>
> ---
> arch/mips/include/asm/mmu_context.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> diff --git a/arch/mips/include/asm/mmu_context.h b/arch/mips/include/asm/mmu_context.h
> index 8201160..ee5a93b 100644
> --- a/arch/mips/include/asm/mmu_context.h
> +++ b/arch/mips/include/asm/mmu_context.h
> @@ -111,13 +111,15 @@ static inline void enter_lazy_tlb(struct mm_struct *mm, struct task_struct *tsk)
> static inline void
> get_new_mmu_context(struct mm_struct *mm, unsigned long cpu)
> {
> +#ifdef CONFIG_KVM
> extern void kvm_local_flush_tlb_all(void);
> +#endif
#ifdef should not be needed around declaration.
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] MIPS: include: mmu_context.h: Replace VIRTUALIZATION with KVM
@ 2013-06-10 12:51 ` Markos Chandras
0 siblings, 0 replies; 5+ messages in thread
From: Markos Chandras @ 2013-06-10 12:51 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-mips, Steven J. Hill
On 06/10/13 12:49, Sergei Shtylyov wrote:
> hello.
>
> On 10-06-2013 15:42, Markos Chandras wrote:
>
>> The kvm_* symbols are only available if KVM is selected.
>
>> Fixes the following linking problem on a randconfig:
>
>> arch/mips/built-in.o: In function `local_flush_tlb_mm':
>> (.text+0x18a94): undefined reference to `kvm_local_flush_tlb_all'
>> arch/mips/built-in.o: In function `local_flush_tlb_range':
>> (.text+0x18d0c): undefined reference to `kvm_local_flush_tlb_all'
>> kernel/built-in.o: In function `__schedule':
>> core.c:(.sched.text+0x2a00): undefined reference to
>> `kvm_local_flush_tlb_all'
>> mm/built-in.o: In function `use_mm':
>> (.text+0x30214): undefined reference to `kvm_local_flush_tlb_all'
>> fs/built-in.o: In function `flush_old_exec':
>> (.text+0xf0a0): undefined reference to `kvm_local_flush_tlb_all'
>> make: *** [vmlinux] Error 1
>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>
>> ---
>> arch/mips/include/asm/mmu_context.h | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>> diff --git a/arch/mips/include/asm/mmu_context.h
>> b/arch/mips/include/asm/mmu_context.h
>> index 8201160..ee5a93b 100644
>> --- a/arch/mips/include/asm/mmu_context.h
>> +++ b/arch/mips/include/asm/mmu_context.h
>> @@ -111,13 +111,15 @@ static inline void enter_lazy_tlb(struct
>> mm_struct *mm, struct task_struct *tsk)
>> static inline void
>> get_new_mmu_context(struct mm_struct *mm, unsigned long cpu)
>> {
>> +#ifdef CONFIG_KVM
>> extern void kvm_local_flush_tlb_all(void);
>> +#endif
>
> #ifdef should not be needed around declaration.
>
> WBR, Sergei
>
Hi Sergei,
You are right. I will send a new version of this patch.
--
markos
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] MIPS: include: mmu_context.h: Replace VIRTUALIZATION with KVM
@ 2013-06-10 12:51 ` Markos Chandras
0 siblings, 0 replies; 5+ messages in thread
From: Markos Chandras @ 2013-06-10 12:51 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-mips, Steven J. Hill
On 06/10/13 12:49, Sergei Shtylyov wrote:
> hello.
>
> On 10-06-2013 15:42, Markos Chandras wrote:
>
>> The kvm_* symbols are only available if KVM is selected.
>
>> Fixes the following linking problem on a randconfig:
>
>> arch/mips/built-in.o: In function `local_flush_tlb_mm':
>> (.text+0x18a94): undefined reference to `kvm_local_flush_tlb_all'
>> arch/mips/built-in.o: In function `local_flush_tlb_range':
>> (.text+0x18d0c): undefined reference to `kvm_local_flush_tlb_all'
>> kernel/built-in.o: In function `__schedule':
>> core.c:(.sched.text+0x2a00): undefined reference to
>> `kvm_local_flush_tlb_all'
>> mm/built-in.o: In function `use_mm':
>> (.text+0x30214): undefined reference to `kvm_local_flush_tlb_all'
>> fs/built-in.o: In function `flush_old_exec':
>> (.text+0xf0a0): undefined reference to `kvm_local_flush_tlb_all'
>> make: *** [vmlinux] Error 1
>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>
>> ---
>> arch/mips/include/asm/mmu_context.h | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>> diff --git a/arch/mips/include/asm/mmu_context.h
>> b/arch/mips/include/asm/mmu_context.h
>> index 8201160..ee5a93b 100644
>> --- a/arch/mips/include/asm/mmu_context.h
>> +++ b/arch/mips/include/asm/mmu_context.h
>> @@ -111,13 +111,15 @@ static inline void enter_lazy_tlb(struct
>> mm_struct *mm, struct task_struct *tsk)
>> static inline void
>> get_new_mmu_context(struct mm_struct *mm, unsigned long cpu)
>> {
>> +#ifdef CONFIG_KVM
>> extern void kvm_local_flush_tlb_all(void);
>> +#endif
>
> #ifdef should not be needed around declaration.
>
> WBR, Sergei
>
Hi Sergei,
You are right. I will send a new version of this patch.
--
markos
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-10 12:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-10 11:42 [PATCH] MIPS: include: mmu_context.h: Replace VIRTUALIZATION with KVM Markos Chandras
2013-06-10 11:42 ` Markos Chandras
2013-06-10 11:49 ` Sergei Shtylyov
2013-06-10 12:51 ` Markos Chandras
2013-06-10 12:51 ` Markos Chandras
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.