* [PATCH] ASoC: adav80x: Select SND_SOC_ADAV80X if SND_SOC_I2C_AND_SPI
@ 2013-06-10 13:20 Axel Lin
2013-06-10 13:24 ` Lars-Peter Clausen
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2013-06-10 13:20 UTC (permalink / raw)
To: Mark Brown; +Cc: Yi Li, Lars-Peter Clausen, Liam Girdwood, alsa-devel
This driver is useless if both SPI and I2C are not configured.
Thus don't build this driver if both SPI and I2C are not configured.
This patch silences below build warning if both SPI and I2C are not configured.
CC sound/soc/codecs/adav80x.o
sound/soc/codecs/adav80x.c:842:12: warning: 'adav80x_bus_probe' defined but not used [-Wunused-function]
sound/soc/codecs/adav80x.c:863:12: warning: 'adav80x_bus_remove' defined but not used [-Wunused-function]
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index c90d298..6234900 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -19,7 +19,7 @@ config SND_SOC_ALL_CODECS
select SND_SOC_AD1980 if SND_SOC_AC97_BUS
select SND_SOC_AD73311
select SND_SOC_ADAU1373 if I2C
- select SND_SOC_ADAV80X
+ select SND_SOC_ADAV80X if SND_SOC_I2C_AND_SPI
select SND_SOC_ADS117X
select SND_SOC_AK4104 if SPI_MASTER
select SND_SOC_AK4535 if I2C
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: adav80x: Select SND_SOC_ADAV80X if SND_SOC_I2C_AND_SPI
2013-06-10 13:20 [PATCH] ASoC: adav80x: Select SND_SOC_ADAV80X if SND_SOC_I2C_AND_SPI Axel Lin
@ 2013-06-10 13:24 ` Lars-Peter Clausen
2013-06-10 14:21 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Lars-Peter Clausen @ 2013-06-10 13:24 UTC (permalink / raw)
To: Axel Lin; +Cc: Yi Li, Mark Brown, Liam Girdwood, alsa-devel
On 06/10/2013 03:20 PM, Axel Lin wrote:
> This driver is useless if both SPI and I2C are not configured.
> Thus don't build this driver if both SPI and I2C are not configured.
>
> This patch silences below build warning if both SPI and I2C are not configured.
>
> CC sound/soc/codecs/adav80x.o
> sound/soc/codecs/adav80x.c:842:12: warning: 'adav80x_bus_probe' defined but not used [-Wunused-function]
> sound/soc/codecs/adav80x.c:863:12: warning: 'adav80x_bus_remove' defined but not used [-Wunused-function]
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Yep, wanted to send the same patch sometime in the next days, since this
actually also fixes a compile error in case of I2C=m and SPI=y.
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> sound/soc/codecs/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index c90d298..6234900 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -19,7 +19,7 @@ config SND_SOC_ALL_CODECS
> select SND_SOC_AD1980 if SND_SOC_AC97_BUS
> select SND_SOC_AD73311
> select SND_SOC_ADAU1373 if I2C
> - select SND_SOC_ADAV80X
> + select SND_SOC_ADAV80X if SND_SOC_I2C_AND_SPI
> select SND_SOC_ADS117X
> select SND_SOC_AK4104 if SPI_MASTER
> select SND_SOC_AK4535 if I2C
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: adav80x: Select SND_SOC_ADAV80X if SND_SOC_I2C_AND_SPI
2013-06-10 13:24 ` Lars-Peter Clausen
@ 2013-06-10 14:21 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-06-10 14:21 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: Yi Li, Axel Lin, Liam Girdwood, alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 228 bytes --]
On Mon, Jun 10, 2013 at 03:24:30PM +0200, Lars-Peter Clausen wrote:
> Yep, wanted to send the same patch sometime in the next days, since this
> actually also fixes a compile error in case of I2C=m and SPI=y.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-10 14:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-10 13:20 [PATCH] ASoC: adav80x: Select SND_SOC_ADAV80X if SND_SOC_I2C_AND_SPI Axel Lin
2013-06-10 13:24 ` Lars-Peter Clausen
2013-06-10 14:21 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.