From: Lars-Peter Clausen <lars@metafoo.de>
To: Axel Lin <axel.lin@ingics.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: ASoC: ssm2518: bug in ssm2518_set_tdm_slot
Date: Mon, 10 Jun 2013 15:56:29 +0200 [thread overview]
Message-ID: <51B5DB0D.9040103@metafoo.de> (raw)
In-Reply-To: <1370871581.22493.0.camel@phoenix>
On 06/10/2013 03:39 PM, Axel Lin wrote:
> ASoC: ssm2518: bug in ssm2518_set_tdm_slot
>
> The code in ssm2518_set_tdm_slot looks wrong:
>
> if (tx_mask == 0 || tx_mask != 0)
> return -EINVAL;
>
> So ssm2518_set_tdm_slot() always returns error.
>
Ah, damm, the second should be rx_mask. Do you want to sent a fix, or want
me to do it?
Thanks,
- Lars
prev parent reply other threads:[~2013-06-10 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 13:39 ASoC: ssm2518: bug in ssm2518_set_tdm_slot Axel Lin
2013-06-10 13:56 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B5DB0D.9040103@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.