ASoC: ssm2518: bug in ssm2518_set_tdm

All of lore.kernel.org
 help / color / mirror / Atom feed

* ASoC: ssm2518: bug in ssm2518_set_tdm_slot
@ 2013-06-10 13:39 Axel Lin
  2013-06-10 13:56 ` Lars-Peter Clausen
  0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2013-06-10 13:39 UTC (permalink / raw)
  To: Mark Brown; +Cc: alsa-devel, Lars-Peter Clausen, Liam Girdwood

ASoC: ssm2518: bug in ssm2518_set_tdm_slot

The code in ssm2518_set_tdm_slot looks wrong:

        if (tx_mask == 0 || tx_mask != 0)
                return -EINVAL;

So ssm2518_set_tdm_slot() always returns error.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: ASoC: ssm2518: bug in ssm2518_set_tdm_slot
  2013-06-10 13:39 ASoC: ssm2518: bug in ssm2518_set_tdm_slot Axel Lin
@ 2013-06-10 13:56 ` Lars-Peter Clausen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars-Peter Clausen @ 2013-06-10 13:56 UTC (permalink / raw)
  To: Axel Lin; +Cc: alsa-devel, Mark Brown, Liam Girdwood

On 06/10/2013 03:39 PM, Axel Lin wrote:
> ASoC: ssm2518: bug in ssm2518_set_tdm_slot
> 
> The code in ssm2518_set_tdm_slot looks wrong:
> 
>         if (tx_mask == 0 || tx_mask != 0)
>                 return -EINVAL;
> 
> So ssm2518_set_tdm_slot() always returns error.
> 

Ah, damm, the second should be rx_mask. Do you want to sent a fix, or want
me to do it?

Thanks,
- Lars

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-06-10 13:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-10 13:39 ASoC: ssm2518: bug in ssm2518_set_tdm_slot Axel Lin
2013-06-10 13:56 ` Lars-Peter Clausen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.