From: Michael Tokarev <mjt@tls.msk.ru>
To: peter.crosthwaite@xilinx.com
Cc: qemu-trivial@nongnu.org, edgar.iglesias@gmail.com,
aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH v1 1/3] char/serial: cosmetic fixes.
Date: Mon, 10 Jun 2013 19:29:23 +0400 [thread overview]
Message-ID: <51B5F0D3.2030504@msgid.tls.msk.ru> (raw)
In-Reply-To: <51B5EE24.5010400@msgid.tls.msk.ru>
10.06.2013 19:17, Michael Tokarev пишет:
> 03.06.2013 09:12, peter.crosthwaite@xilinx.com wrote:
>> From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>>
>> Some cosmetic fixes to char/serial fixing some checkpatch errors.
>
> These are all cosmetic fixes indeed. I weren't sure we're
> applying stylistic changes by its own. But apparently
> people don't object so I don't see why not, either, except
> that I don't really want to open a can of worms with other
> stylistic patches to come ;)
>
> Applied all 3 to the trivial patches queue.
Actually I didn't apply these. Since patch 2/3 weren't sent to
-trivial, and 3/3 does not apply without it, I'm not sure I want
to apply either of these. Maybe all 3 should be sent to the same
tree? Should I pick the 2/3 too, which wasn't submitted to
-trivial?
Thank you!
/mjt
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: peter.crosthwaite@xilinx.com
Cc: qemu-trivial@nongnu.org, edgar.iglesias@gmail.com,
aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/3] char/serial: cosmetic fixes.
Date: Mon, 10 Jun 2013 19:29:23 +0400 [thread overview]
Message-ID: <51B5F0D3.2030504@msgid.tls.msk.ru> (raw)
In-Reply-To: <51B5EE24.5010400@msgid.tls.msk.ru>
10.06.2013 19:17, Michael Tokarev пишет:
> 03.06.2013 09:12, peter.crosthwaite@xilinx.com wrote:
>> From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>>
>> Some cosmetic fixes to char/serial fixing some checkpatch errors.
>
> These are all cosmetic fixes indeed. I weren't sure we're
> applying stylistic changes by its own. But apparently
> people don't object so I don't see why not, either, except
> that I don't really want to open a can of worms with other
> stylistic patches to come ;)
>
> Applied all 3 to the trivial patches queue.
Actually I didn't apply these. Since patch 2/3 weren't sent to
-trivial, and 3/3 does not apply without it, I'm not sure I want
to apply either of these. Maybe all 3 should be sent to the same
tree? Should I pick the 2/3 too, which wasn't submitted to
-trivial?
Thank you!
/mjt
next prev parent reply other threads:[~2013-06-10 15:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 5:11 [Qemu-devel] [PATCH v1 0/3] Serial cleanup peter.crosthwaite
2013-06-03 5:12 ` [Qemu-trivial] [PATCH v1 1/3] char/serial: cosmetic fixes peter.crosthwaite
2013-06-03 5:12 ` [Qemu-devel] " peter.crosthwaite
2013-06-10 13:32 ` [Qemu-trivial] " Andreas Färber
2013-06-10 13:32 ` Andreas Färber
2013-06-10 15:17 ` [Qemu-trivial] " Michael Tokarev
2013-06-10 15:17 ` [Qemu-devel] " Michael Tokarev
2013-06-10 15:29 ` Michael Tokarev [this message]
2013-06-10 15:29 ` Michael Tokarev
2013-06-10 22:24 ` [Qemu-trivial] [Qemu-devel] " Peter Crosthwaite
2013-06-10 22:24 ` [Qemu-devel] [Qemu-trivial] " Peter Crosthwaite
2013-06-03 5:13 ` [Qemu-devel] [PATCH v1 2/3] char/serial: Use generic Fifo8 peter.crosthwaite
2013-06-03 5:14 ` [Qemu-trivial] [PATCH v1 3/3] char/serial: serial_ioport_write: Factor out common code peter.crosthwaite
2013-06-03 5:14 ` [Qemu-devel] " peter.crosthwaite
2013-06-10 13:35 ` [Qemu-trivial] " Andreas Färber
2013-06-10 13:35 ` Andreas Färber
2013-06-10 10:23 ` [Qemu-trivial] [PATCH v1 0/3] Serial cleanup Peter Crosthwaite
2013-06-10 10:23 ` [Qemu-devel] " Peter Crosthwaite
2013-06-10 11:49 ` [Qemu-trivial] " Andreas Färber
2013-06-10 11:49 ` Andreas Färber
2013-06-10 12:09 ` [Qemu-trivial] " Peter Crosthwaite
2013-06-10 12:09 ` Peter Crosthwaite
2013-06-11 11:23 ` [Qemu-trivial] " Michael Tokarev
2013-06-11 11:23 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B5F0D3.2030504@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=aliguori@us.ibm.com \
--cc=edgar.iglesias@gmail.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.