From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/11] Convert GPIO Davinci to platform driver
Date: Tue, 11 Jun 2013 10:09:17 +0530 [thread overview]
Message-ID: <51B6A9F5.5020300@ti.com> (raw)
In-Reply-To: <518397C60809E147AF5323E0420B992E3EAD887C@DBDE04.ent.ti.com>
On 6/10/2013 2:32 PM, Philip, Avinash wrote:
> On Fri, Jun 07, 2013 at 13:40:52, Nori, Sekhar wrote:
>> Hi Avinash,
>>
>> On 5/22/2013 12:40 PM, Philip Avinash wrote:
>>> GPIO Davinci driver converted to platform driver to support DT booting.
>>> In this patch series
>>> - Cleaned gpio Davinci driver code with proper commenting style and appropriate
>>> variable names.
>>> - Create platform driver for GPIO Davinci in da8xx and dm* platforms and removed
>>> gpio related member updation in davinci_soc_info structure.
>>> - DT support added for da850 board and tested on da850 EVM.
>>> - Remove soc_info reference in the gpio davinci driver and start uses
>>> gpiolib interface.
>>
>> Can you please document which platforms this series was tested on and how?
>
> This series being tested on da850 EVM. Tested by setting VPIF_DOUT[12] as GPIO
> pin [2] and reading GPIO status from GPIO[7,4]
>
> GPIO[7,4] will reflect the status switch number 8 of the S7 dip switch in DA850 EVM.
>
> Testing Procedure
>
> Requirement GPIO SYSFS support [1]
>
> #echo 116 > /sys/class/gpio/export
> setting GPIO[7,4] as input GPIO
> #echo "in" > /sys/class/gpio/gpio116/direction
> #mount -t debugfs debugfs /sys/kernel/debug
> Reading GPIO pin status
> #cat /sys/kernel/debug/gpio
> #echo 116 > /sys/class/gpio/unexport
>
>
> 1. Enable GPIO SYSFS support through menconfig
> --- GPIO Support
> [ ] Debug GPIO calls
> [ ] /sys/class/gpio/... (sysfs interface)
>
> 2. Patch for pinmux support for GPIO[7,4] is available at
> https://github.com/avinashphilip/am335x_linux/commits/linux_davinci_v3.10_soc_gpio
Can you check interrupt generation too since there are significant
changes in that area? You can generate an interrupt using the MMC/SD
card detect pin (inserting an MMC/SD card into the slot should generate
an interrupt). You can also write a new value to any GPIO pin. That will
also trigger an interrupt.
It will be nice if you can test this series on DM365 as well (read/write
as well as interrupt).
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: "Philip, Avinash" <avinashphilip@ti.com>
Cc: "khilman@deeprootsystems.com" <khilman@deeprootsystems.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/11] Convert GPIO Davinci to platform driver
Date: Tue, 11 Jun 2013 10:09:17 +0530 [thread overview]
Message-ID: <51B6A9F5.5020300@ti.com> (raw)
In-Reply-To: <518397C60809E147AF5323E0420B992E3EAD887C@DBDE04.ent.ti.com>
On 6/10/2013 2:32 PM, Philip, Avinash wrote:
> On Fri, Jun 07, 2013 at 13:40:52, Nori, Sekhar wrote:
>> Hi Avinash,
>>
>> On 5/22/2013 12:40 PM, Philip Avinash wrote:
>>> GPIO Davinci driver converted to platform driver to support DT booting.
>>> In this patch series
>>> - Cleaned gpio Davinci driver code with proper commenting style and appropriate
>>> variable names.
>>> - Create platform driver for GPIO Davinci in da8xx and dm* platforms and removed
>>> gpio related member updation in davinci_soc_info structure.
>>> - DT support added for da850 board and tested on da850 EVM.
>>> - Remove soc_info reference in the gpio davinci driver and start uses
>>> gpiolib interface.
>>
>> Can you please document which platforms this series was tested on and how?
>
> This series being tested on da850 EVM. Tested by setting VPIF_DOUT[12] as GPIO
> pin [2] and reading GPIO status from GPIO[7,4]
>
> GPIO[7,4] will reflect the status switch number 8 of the S7 dip switch in DA850 EVM.
>
> Testing Procedure
>
> Requirement GPIO SYSFS support [1]
>
> #echo 116 > /sys/class/gpio/export
> setting GPIO[7,4] as input GPIO
> #echo "in" > /sys/class/gpio/gpio116/direction
> #mount -t debugfs debugfs /sys/kernel/debug
> Reading GPIO pin status
> #cat /sys/kernel/debug/gpio
> #echo 116 > /sys/class/gpio/unexport
>
>
> 1. Enable GPIO SYSFS support through menconfig
> --- GPIO Support
> [ ] Debug GPIO calls
> [ ] /sys/class/gpio/... (sysfs interface)
>
> 2. Patch for pinmux support for GPIO[7,4] is available at
> https://github.com/avinashphilip/am335x_linux/commits/linux_davinci_v3.10_soc_gpio
Can you check interrupt generation too since there are significant
changes in that area? You can generate an interrupt using the MMC/SD
card detect pin (inserting an MMC/SD card into the slot should generate
an interrupt). You can also write a new value to any GPIO pin. That will
also trigger an interrupt.
It will be nice if you can test this series on DM365 as well (read/write
as well as interrupt).
Thanks,
Sekhar
next prev parent reply other threads:[~2013-06-11 4:39 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 7:10 [PATCH 00/11] Convert GPIO Davinci to platform driver Philip Avinash
2013-05-22 7:10 ` Philip Avinash
2013-05-22 7:10 ` [PATCH 01/11] ARM: davinci: GPIO: Add platform data structure Philip Avinash
2013-05-22 7:10 ` Philip Avinash
2013-05-30 18:06 ` Linus Walleij
2013-05-30 18:06 ` Linus Walleij
2013-06-11 10:36 ` Sekhar Nori
2013-06-11 10:36 ` Sekhar Nori
2013-06-11 11:10 ` Sergei Shtylyov
2013-06-11 11:10 ` Sergei Shtylyov
2013-06-11 12:53 ` Philip, Avinash
2013-06-11 12:53 ` Philip, Avinash
2013-05-22 7:10 ` [PATCH 02/11] gpio: davinci: coding style correction Philip Avinash
2013-05-22 7:10 ` Philip Avinash
2013-05-22 12:59 ` Sergei Shtylyov
2013-05-22 12:59 ` Sergei Shtylyov
2013-05-23 6:27 ` Philip, Avinash
2013-05-23 6:27 ` Philip, Avinash
2013-05-22 14:40 ` Russell King - ARM Linux
2013-05-22 14:40 ` Russell King - ARM Linux
2013-05-23 6:27 ` Philip, Avinash
2013-05-23 6:27 ` Philip, Avinash
2013-06-11 11:42 ` Sekhar Nori
2013-06-11 11:42 ` Sekhar Nori
2013-05-22 7:10 ` [PATCH 03/11] gpio: davinci: Modify to platform driver Philip Avinash
2013-05-22 7:10 ` Philip Avinash
2013-05-30 18:12 ` Linus Walleij
2013-05-30 18:12 ` Linus Walleij
2013-06-11 11:56 ` Sekhar Nori
2013-06-11 11:56 ` Sekhar Nori
2013-06-11 12:55 ` Philip, Avinash
2013-06-11 12:55 ` Philip, Avinash
2013-06-12 7:43 ` Sekhar Nori
2013-06-12 7:43 ` Sekhar Nori
2013-06-12 12:10 ` Philip, Avinash
2013-06-12 12:10 ` Philip, Avinash
2013-06-13 6:17 ` Sekhar Nori
2013-06-13 6:17 ` Sekhar Nori
2013-06-13 7:32 ` Philip, Avinash
2013-06-13 7:32 ` Philip, Avinash
2013-06-13 8:29 ` Sekhar Nori
2013-06-13 8:29 ` Sekhar Nori
2013-06-13 9:18 ` Philip, Avinash
2013-06-13 9:18 ` Philip, Avinash
2013-05-22 7:10 ` [PATCH 04/11] ARM: davinci: da8xx: creation of gpio platform device Philip Avinash
2013-05-22 7:10 ` Philip Avinash
2013-05-30 18:14 ` Linus Walleij
2013-05-30 18:14 ` Linus Walleij
2013-05-22 7:10 ` [PATCH 05/11] ARM: davinci: creation of gpio platform device for dm platforms Philip Avinash
2013-05-22 7:10 ` Philip Avinash
2013-05-30 18:15 ` Linus Walleij
2013-05-30 18:15 ` Linus Walleij
2013-05-22 7:10 ` [PATCH 06/11] ARM: davinci: da8xx: gpio device creation Philip Avinash
2013-05-22 7:10 ` Philip Avinash
2013-05-30 18:16 ` Linus Walleij
2013-05-30 18:16 ` Linus Walleij
2013-05-22 7:10 ` [PATCH 07/11] ARM: davinci: create davinci gpio device for dm platforms Philip Avinash
2013-05-22 7:10 ` Philip Avinash
2013-05-30 18:16 ` Linus Walleij
2013-05-30 18:16 ` Linus Walleij
2013-05-22 7:10 ` [PATCH 08/11] ARM: davinci: start using gpiolib support Philip Avinash
2013-05-22 7:10 ` Philip Avinash
2013-05-30 18:19 ` Linus Walleij
2013-05-30 18:19 ` Linus Walleij
2013-05-22 7:10 ` [PATCH 09/11] gpio: davinci: DT changes for driver Philip Avinash
2013-05-22 7:10 ` Philip Avinash
2013-05-22 7:10 ` Philip Avinash
2013-05-30 18:25 ` Linus Walleij
2013-05-30 18:25 ` Linus Walleij
2013-06-10 11:45 ` Philip, Avinash
2013-06-10 11:45 ` Philip, Avinash
2013-06-10 11:45 ` Philip, Avinash
2013-05-22 7:10 ` [PATCH 10/11] ARM: davinci: da850: add GPIO DT entries Philip Avinash
2013-05-22 7:10 ` Philip Avinash
2013-05-22 7:10 ` [PATCH 11/11] ARM: davinci: da850 evm: add GPIO DT data Philip Avinash
2013-05-22 7:10 ` Philip Avinash
2013-05-30 18:26 ` Linus Walleij
2013-05-30 18:26 ` Linus Walleij
2013-05-30 18:04 ` [PATCH 00/11] Convert GPIO Davinci to platform driver Linus Walleij
2013-05-30 18:04 ` Linus Walleij
2013-06-07 8:10 ` Sekhar Nori
2013-06-07 8:10 ` Sekhar Nori
2013-06-10 9:02 ` Philip, Avinash
2013-06-10 9:02 ` Philip, Avinash
2013-06-11 4:39 ` Sekhar Nori [this message]
2013-06-11 4:39 ` Sekhar Nori
2013-06-11 6:49 ` Philip, Avinash
2013-06-11 6:49 ` Philip, Avinash
2013-06-11 11:40 ` Sekhar Nori
2013-06-11 11:40 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B6A9F5.5020300@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.