All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <fabio.estevam@freescale.com>
To: Oskar Schirmer <oskar@scara.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
	Wolfram Sang <w.sang@pengutronix.de>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org,
	Zeng Zhaoming <zengzm.kernel@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] sound/sgtl5000: fix codec register initial values and mask
Date: Tue, 11 Jun 2013 09:20:24 -0300	[thread overview]
Message-ID: <51B71608.3000302@freescale.com> (raw)
In-Reply-To: <1370938320-6554-1-git-send-email-oskar@scara.com>

Hi Oskar,

On 06/11/2013 05:12 AM, Oskar Schirmer wrote:
> According to documentation bit 3:2 in register SSS_CTRL are
> reserved and zero, so initially setting the register to 0x0008
> does not make much sense. Instead, bit 4 should be marked set,
> as this is the power up default.
>
> Further, mask computation in declarative part is obviously wrong:
> Fix FRAC DIVISOR to provide an 11 bit mask correctly.
>
> Signed-off-by: Oskar Schirmer <oskar@scara.com>

Please rebase your patch against Mark Brown's topic/sgtl5000 branch:

https://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/log/?h=topic/sgtl5000

After that, you can add my:

Tested-by: Fabio Estevam <fabio.estevam@freescale.com>

WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <fabio.estevam@freescale.com>
To: Oskar Schirmer <oskar@scara.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	<linux-kernel@vger.kernel.org>,
	Zeng Zhaoming <zengzm.kernel@gmail.com>,
	<alsa-devel@alsa-project.org>, Takashi Iwai <tiwai@suse.de>,
	Jaroslav Kysela <perex@perex.cz>,
	Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: [PATCH] sound/sgtl5000: fix codec register initial values and mask
Date: Tue, 11 Jun 2013 09:20:24 -0300	[thread overview]
Message-ID: <51B71608.3000302@freescale.com> (raw)
In-Reply-To: <1370938320-6554-1-git-send-email-oskar@scara.com>

Hi Oskar,

On 06/11/2013 05:12 AM, Oskar Schirmer wrote:
> According to documentation bit 3:2 in register SSS_CTRL are
> reserved and zero, so initially setting the register to 0x0008
> does not make much sense. Instead, bit 4 should be marked set,
> as this is the power up default.
>
> Further, mask computation in declarative part is obviously wrong:
> Fix FRAC DIVISOR to provide an 11 bit mask correctly.
>
> Signed-off-by: Oskar Schirmer <oskar@scara.com>

Please rebase your patch against Mark Brown's topic/sgtl5000 branch:

https://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/log/?h=topic/sgtl5000

After that, you can add my:

Tested-by: Fabio Estevam <fabio.estevam@freescale.com>


  reply	other threads:[~2013-06-11 12:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-11  8:12 [PATCH] sound/sgtl5000: fix codec register initial values and mask Oskar Schirmer
2013-06-11 12:20 ` Fabio Estevam [this message]
2013-06-11 12:20   ` Fabio Estevam
2013-06-11 15:22   ` [PATCH v2] " Oskar Schirmer
2013-06-11 16:01     ` Fabio Estevam
2013-06-11 16:01       ` Fabio Estevam
2013-06-12 16:08       ` Mark Brown
2013-06-12 16:08         ` Mark Brown
2013-06-19 13:16       ` [PATCH v3] sound/sgtl5000: fix codec register initial values and handling Oskar Schirmer
2013-06-19 15:26         ` Mark Brown
2013-06-19 15:26           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B71608.3000302@freescale.com \
    --to=fabio.estevam@freescale.com \
    --cc=akpm@linux-foundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oskar@scara.com \
    --cc=tiwai@suse.de \
    --cc=w.sang@pengutronix.de \
    --cc=zengzm.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.