From: wenchao <wenchaolinux@gmail.com>
To: Asias He <asias@redhat.com>
Cc: kvm@vger.kernel.org, mst@redhat.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
virtualization@lists.linux-foundation.org,
linux-next@vger.kernel.org, wenchaolinuxkvm@gmail.com,
pbonzini@redhat.com
Subject: Re: [PATCH] vhost-scsi: return -ENOENT when no matching tcm_vhost_tpg found
Date: Wed, 12 Jun 2013 09:39:50 +0800 [thread overview]
Message-ID: <51B7D166.3000109@gmail.com> (raw)
In-Reply-To: <20130528092539.GA22269@hj.localdomain>
cc to Greg for 3.9.
> On Tue, May 28, 2013 at 04:54:44PM +0800, Wenchao Xia wrote:
>> ioctl for VHOST_SCSI_SET_ENDPOINT report file exist errori, when I forget
>> to set it correctly in configfs, make user confused. Actually it fail
>> to find a matching one, so change the error value.
>>
>> Signed-off-by: Wenchao Xia <wenchaolinux@gmail.com>
>
> Acked-by: Asias He <asias@redhat.com>
>
> BTW, It would be nice to print more informative info in qemu when wwpn
> is not available as well.
>
>> ---
>> drivers/vhost/scsi.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
>> index 7014202..6325b1d 100644
>> --- a/drivers/vhost/scsi.c
>> +++ b/drivers/vhost/scsi.c
>> @@ -1219,7 +1219,7 @@ static int vhost_scsi_set_endpoint(
>> }
>> ret = 0;
>> } else {
>> - ret = -EEXIST;
>> + ret = -ENOENT;
>> }
>>
>> /*
>> --
>> 1.7.1
>>
>
next prev parent reply other threads:[~2013-06-12 1:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 8:54 [PATCH] vhost-scsi: return -ENOENT when no matching tcm_vhost_tpg found Wenchao Xia
2013-05-28 9:25 ` Asias He
2013-06-12 1:39 ` wenchao [this message]
2013-06-12 3:03 ` Greg Kroah-Hartman
2013-06-12 3:03 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2013-05-28 8:54 Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B7D166.3000109@gmail.com \
--to=wenchaolinux@gmail.com \
--cc=asias@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wenchaolinuxkvm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.