From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
qemu-stable@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Cam Macdonell <cam@cs.ualberta.ca>,
Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH v2 2/2] ivshmem: add missing error exit(2)
Date: Wed, 12 Jun 2013 13:18:15 +0400 [thread overview]
Message-ID: <51B83CD7.5030001@msgid.tls.msk.ru> (raw)
In-Reply-To: <20130612072221.GA946@stefanha-thinkpad.muc.redhat.com>
12.06.2013 11:22, Stefan Hajnoczi wrote:
>> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
>> index a19a6d6..5658f73 100644
>> --- a/hw/misc/ivshmem.c
>> +++ b/hw/misc/ivshmem.c
>> @@ -735,6 +735,7 @@ static int pci_ivshmem_init(PCIDevice *dev)
>>
>> if (s->shmobj == NULL) {
>> fprintf(stderr, "Must specify 'chardev' or 'shm' to ivshmem\n");
>> + exit(1);
>> }
>>
>> IVSHMEM_DPRINTF("using shm_open (shm object = %s)\n", s->shmobj);
>
> Ping?
Ow. I missed it because part 1/2 were applied to scsi branch by
Paolo and I marked whole thread as "done".
Applied this 2/2 now to the trivial patches tree.
Thank you!
/mjt
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
qemu-stable@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Cam Macdonell <cam@cs.ualberta.ca>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/2] ivshmem: add missing error exit(2)
Date: Wed, 12 Jun 2013 13:18:15 +0400 [thread overview]
Message-ID: <51B83CD7.5030001@msgid.tls.msk.ru> (raw)
In-Reply-To: <20130612072221.GA946@stefanha-thinkpad.muc.redhat.com>
12.06.2013 11:22, Stefan Hajnoczi wrote:
>> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
>> index a19a6d6..5658f73 100644
>> --- a/hw/misc/ivshmem.c
>> +++ b/hw/misc/ivshmem.c
>> @@ -735,6 +735,7 @@ static int pci_ivshmem_init(PCIDevice *dev)
>>
>> if (s->shmobj == NULL) {
>> fprintf(stderr, "Must specify 'chardev' or 'shm' to ivshmem\n");
>> + exit(1);
>> }
>>
>> IVSHMEM_DPRINTF("using shm_open (shm object = %s)\n", s->shmobj);
>
> Ping?
Ow. I missed it because part 1/2 were applied to scsi branch by
Paolo and I marked whole thread as "done".
Applied this 2/2 now to the trivial patches tree.
Thank you!
/mjt
next prev parent reply other threads:[~2013-06-12 9:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 8:58 [Qemu-trivial] [PATCH v2 0/2] vhost-scsi and ivshmem fixes for Coverity issues Stefan Hajnoczi
2013-06-03 8:58 ` [Qemu-devel] " Stefan Hajnoczi
2013-06-03 8:58 ` [Qemu-trivial] [PATCH v2 1/2] vhost-scsi: fix k->set_guest_notifiers() NULL dereference Stefan Hajnoczi
2013-06-03 8:58 ` [Qemu-devel] " Stefan Hajnoczi
2013-06-03 9:07 ` [Qemu-trivial] " Paolo Bonzini
2013-06-03 9:07 ` [Qemu-devel] " Paolo Bonzini
2013-06-03 8:58 ` [Qemu-trivial] [PATCH v2 2/2] ivshmem: add missing error exit(2) Stefan Hajnoczi
2013-06-03 8:58 ` [Qemu-devel] " Stefan Hajnoczi
2013-06-03 12:26 ` [Qemu-trivial] " Eric Blake
2013-06-03 12:26 ` [Qemu-devel] " Eric Blake
2013-06-03 13:11 ` [Qemu-trivial] " Stefan Hajnoczi
2013-06-03 13:11 ` [Qemu-devel] " Stefan Hajnoczi
2013-06-12 8:49 ` [Qemu-trivial] " Andreas Färber
2013-06-12 8:49 ` Andreas Färber
2013-06-12 7:22 ` [Qemu-trivial] " Stefan Hajnoczi
2013-06-12 7:22 ` [Qemu-devel] " Stefan Hajnoczi
2013-06-12 9:18 ` Michael Tokarev [this message]
2013-06-12 9:18 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B83CD7.5030001@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=cam@cs.ualberta.ca \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.