From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH trivial] main-loop: do not include slirp/slirp.h, use libslirp.h instead
Date: Wed, 12 Jun 2013 08:50:16 -0400 [thread overview]
Message-ID: <51B86E88.2020405@redhat.com> (raw)
In-Reply-To: <1371040588-17938-1-git-send-email-mjt@msgid.tls.msk.ru>
Il 12/06/2013 08:36, Michael Tokarev ha scritto:
>
> Including slirp/slirp.h is somewhat dangerous since it redefines
> errno on WIN32, so any file including it may misbehave wrt errno.
>
> Unfortunately libslirp isn't self-contained, it needs declaration
> of struct in_addr, which is provided by qemu/sockets.h. Maybe
> instead of #including qemu/sockets.h before libslirp.h, it is
> better to make the latter self-contained.
Yeah, but I agree with having the smallest patch for now.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH trivial] main-loop: do not include slirp/slirp.h, use libslirp.h instead
Date: Wed, 12 Jun 2013 08:50:16 -0400 [thread overview]
Message-ID: <51B86E88.2020405@redhat.com> (raw)
In-Reply-To: <1371040588-17938-1-git-send-email-mjt@msgid.tls.msk.ru>
Il 12/06/2013 08:36, Michael Tokarev ha scritto:
>
> Including slirp/slirp.h is somewhat dangerous since it redefines
> errno on WIN32, so any file including it may misbehave wrt errno.
>
> Unfortunately libslirp isn't self-contained, it needs declaration
> of struct in_addr, which is provided by qemu/sockets.h. Maybe
> instead of #including qemu/sockets.h before libslirp.h, it is
> better to make the latter self-contained.
Yeah, but I agree with having the smallest patch for now.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2013-06-12 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 12:36 [Qemu-trivial] [PATCH trivial] main-loop: do not include slirp/slirp.h, use libslirp.h instead Michael Tokarev
2013-06-12 12:36 ` [Qemu-devel] " Michael Tokarev
2013-06-12 12:50 ` Paolo Bonzini [this message]
2013-06-12 12:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B86E88.2020405@redhat.com \
--to=pbonzini@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.