Re: [PATCH] mm/page_alloc: don't re-init pageset in zone_pcp_update()

[Cody P Schafer <cody@linux.vnet.ibm.com>]

> Anyhow, a reorganized (and clearer) changelog with the same content
> follows:
> ---

I made a few wording tweaks:
---
mm/page_alloc: don't re-init pageset in zone_pcp_update()

When memory hotplug is triggered, we call pageset_init() on
per-cpu-pagesets which both contain pages and are in use, causing both
the leakage of those pages and (potentially) bad behaviour if a page is
allocated from a pageset while it is being cleared.

Avoid this by factoring out pageset_set_high_and_batch() (which contains 
all needed logic too set a pageset's ->high and ->batch inrespective of 
system state) from zone_pageset_init() and using the new 
pageset_set_high_and_batch() instead of zone_pageset_init() in 
zone_pcp_update().

Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>




--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>