From: Eric Sandeen <sandeen@redhat.com>
To: Anand Jain <Anand.Jain@oracle.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: btrfs-progs and btrfs code similar why ?
Date: Wed, 12 Jun 2013 23:44:55 -0500 [thread overview]
Message-ID: <51B94E47.1070900@redhat.com> (raw)
In-Reply-To: <51B942E3.8000701@oracle.com>
On 6/12/13 10:56 PM, Anand Jain wrote:
>
>
> Per wiki an idea seems to maintain same code (probably
> as much as possible) between btrfs-progs and btrfs
>
> There must have been a/few critical advantage, but
> what are they ?
>
> Thanks, Anand
Because they work with the same on-disk structures, and need
to perform many of the same tasks. So using the same code base
means bugs get fixed once, features get written once, there is
built-in consistency, more coverage, etc.
I was just looking at an ext4 bug tonight where offline vs.
online resize result in different filesystem images. In one
case it leads to a bug, in the other it doesn't. The complex
resize code is implemented twice, and implemented differently.
Less code is good. Consistency is good.
-Eric
next prev parent reply other threads:[~2013-06-13 4:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 3:56 btrfs-progs and btrfs code similar why ? Anand Jain
2013-06-13 4:44 ` Eric Sandeen [this message]
2013-06-14 1:53 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B94E47.1070900@redhat.com \
--to=sandeen@redhat.com \
--cc=Anand.Jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.