From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Change the internal SRAM memory type MT_MEMORY_NONCACHED
Date: Thu, 13 Jun 2013 15:19:58 +0200 [thread overview]
Message-ID: <51B9C6FE.7000302@atmel.com> (raw)
In-Reply-To: <1370657863-8725-1-git-send-email-wenyou.yang@atmel.com>
On 08/06/2013 04:17, Wenyou Yang :
> Because MT_DEVICE is not executable in armv7, we change
> the internal SRAM memory type to MT_MEMORY_NONCACHED.
> As it seems that caching this internal SRAM memory is not necessary,
> we chose the this memory type.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
But Russell, can we have your advice on this as you made us re-think
about that during previous patch discussion?
Bye,
> ---
> arch/arm/mach-at91/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/setup.c b/arch/arm/mach-at91/setup.c
> index a33d4b5..98d55ef 100644
> --- a/arch/arm/mach-at91/setup.c
> +++ b/arch/arm/mach-at91/setup.c
> @@ -84,7 +84,7 @@ void __init at91_init_sram(int bank, unsigned long base, unsigned int length)
>
> desc->pfn = __phys_to_pfn(base);
> desc->length = length;
> - desc->type = MT_DEVICE;
> + desc->type = MT_MEMORY_NONCACHED;
>
> pr_info("AT91: sram at 0x%lx of 0x%x mapped at 0x%lx\n",
> base, length, desc->virtual);
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Wenyou Yang <wenyou.yang@atmel.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: <linux-arm-kernel@lists.infradead.org>, <linux@maxim.org.za>,
<plagnioj@jcrosoft.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Change the internal SRAM memory type MT_MEMORY_NONCACHED
Date: Thu, 13 Jun 2013 15:19:58 +0200 [thread overview]
Message-ID: <51B9C6FE.7000302@atmel.com> (raw)
In-Reply-To: <1370657863-8725-1-git-send-email-wenyou.yang@atmel.com>
On 08/06/2013 04:17, Wenyou Yang :
> Because MT_DEVICE is not executable in armv7, we change
> the internal SRAM memory type to MT_MEMORY_NONCACHED.
> As it seems that caching this internal SRAM memory is not necessary,
> we chose the this memory type.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
But Russell, can we have your advice on this as you made us re-think
about that during previous patch discussion?
Bye,
> ---
> arch/arm/mach-at91/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/setup.c b/arch/arm/mach-at91/setup.c
> index a33d4b5..98d55ef 100644
> --- a/arch/arm/mach-at91/setup.c
> +++ b/arch/arm/mach-at91/setup.c
> @@ -84,7 +84,7 @@ void __init at91_init_sram(int bank, unsigned long base, unsigned int length)
>
> desc->pfn = __phys_to_pfn(base);
> desc->length = length;
> - desc->type = MT_DEVICE;
> + desc->type = MT_MEMORY_NONCACHED;
>
> pr_info("AT91: sram at 0x%lx of 0x%x mapped at 0x%lx\n",
> base, length, desc->virtual);
>
--
Nicolas Ferre
next prev parent reply other threads:[~2013-06-13 13:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 1:05 [PATCH] Change internal SRAM memory type to "MT_MEMORY_SO" Wenyou Yang
2013-05-20 1:05 ` Wenyou Yang
2013-05-20 1:06 ` [PATCH] ARM: at91: Fix: " Wenyou Yang
2013-05-20 1:06 ` Wenyou Yang
2013-05-21 9:06 ` Nicolas Ferre
2013-05-21 9:06 ` Nicolas Ferre
2013-05-22 0:14 ` Russell King - ARM Linux
2013-05-22 0:14 ` Russell King - ARM Linux
2013-05-24 7:11 ` Yang, Wenyou
2013-05-24 7:11 ` Yang, Wenyou
2013-05-24 11:20 ` Russell King - ARM Linux
2013-05-24 11:20 ` Russell King - ARM Linux
2013-05-24 14:03 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-24 14:03 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-24 16:40 ` Russell King - ARM Linux
2013-05-24 16:40 ` Russell King - ARM Linux
2013-05-24 16:52 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-24 16:52 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-24 16:59 ` Russell King - ARM Linux
2013-05-24 16:59 ` Russell King - ARM Linux
2013-05-24 17:11 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-24 17:11 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-21 9:06 ` [PATCH] " Nicolas Ferre
2013-05-21 9:06 ` Nicolas Ferre
2013-06-08 2:17 ` [PATCH] Change the internal SRAM memory type MT_MEMORY_NONCACHED Wenyou Yang
2013-06-08 2:17 ` Wenyou Yang
2013-06-13 13:19 ` Nicolas Ferre [this message]
2013-06-13 13:19 ` Nicolas Ferre
2013-06-13 13:43 ` Russell King - ARM Linux
2013-06-13 13:43 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B9C6FE.7000302@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.