From: Dave Hansen <dave.hansen@intel.com>
To: linux-ext4@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Theodore Ts'o <tytso@mit.edu>, Jan kara <jack@suse.cz>
Subject: Re: ext4 extent status tree LRU locking
Date: Fri, 14 Jun 2013 08:57:44 -0700 [thread overview]
Message-ID: <51BB3D78.2070907@intel.com> (raw)
In-Reply-To: <20130614140940.GA20401@gmail.com>
On 06/14/2013 07:09 AM, Zheng Liu wrote:
> - INIT_LIST_HEAD(&scanned);
> -
> spin_lock(&sbi->s_es_lru_lock);
> + list_sort(NULL, &sbi->s_es_lru, ext4_inode_touch_time_cmp);
> list_for_each_safe(cur, tmp, &sbi->s_es_lru) {
How long can this list get? I have the feeling this might get a bit
painful, especially on a NUMA machine.
But, it definitely eliminates the spinlock contention that I was seeing.
The top ext4 function in my profiles is way down under 1% of CPU time
now. Thanks for the quick response, and please let me know if you need
any further testing.
next prev parent reply other threads:[~2013-06-14 15:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 23:22 ext4 extent status tree LRU locking Dave Hansen
2013-06-12 7:17 ` Zheng Liu
2013-06-12 15:09 ` Dave Hansen
2013-06-12 16:03 ` Zheng Liu
2013-06-12 17:52 ` Dave Hansen
2013-06-12 20:48 ` Theodore Ts'o
2013-06-13 13:27 ` Zheng Liu
2013-06-13 13:35 ` Theodore Ts'o
2013-06-14 3:27 ` Zheng Liu
2013-06-14 14:09 ` Zheng Liu
2013-06-14 14:02 ` Theodore Ts'o
2013-06-14 17:00 ` Zheng Liu
2013-06-14 18:00 ` Theodore Ts'o
2013-06-17 10:10 ` Zheng Liu
2013-06-17 21:12 ` Dave Hansen
2013-06-18 2:25 ` Zheng Liu
2013-06-18 2:51 ` Theodore Ts'o
2013-06-18 3:49 ` Zheng Liu
2013-06-18 2:47 ` Theodore Ts'o
2013-06-14 15:57 ` Dave Hansen [this message]
2013-06-14 17:11 ` Zheng Liu
2013-06-14 16:55 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BB3D78.2070907@intel.com \
--to=dave.hansen@intel.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.