From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] ARM: shmobile: BOCK-W: add Ether support
Date: Sun, 16 Jun 2013 16:14:12 +0000 [thread overview]
Message-ID: <51BDE454.5000006@cogentembedded.com> (raw)
In-Reply-To: <20130612140905.GM32751@verge.net.au>
Hello.
On 12.06.2013 18:09, Simon Horman wrote:
>> Register Ether device from bockw_init(), passing the platform data to it, adding
>> only the RMII pin group to bockw_pinctrl_map[]. Although the LINK signal exists
>> on the board, it's connected to the link/activity LED output of the PHY, thus
>> the link disappears and reappears after each packet. We'd be better off ignoring
>> such signal and getting the link state from the PHY indirectly.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> The patch is atop of Simon's 'renesas.git' repo, 'renesas-next-20130528' tag
>> and the USB patches just reposted. I decided to move it ahead of the VIN patches
>> as it can be merged right now since all dependecies have been already met.
> Thanks, queued up in the boards branch.
Has this been pulled by Olof/Arnd? If not, is it possible to amend
this patch or should I send an incremental one? I forgot to update the
platform device name from "sh-eth" to "r8a777x-ether" in the PinMux
table, in accordance to the R8A7778 Ether device name fix. It would be
good if this got into 3.11 as otherwise Ether support on BOCK-W wouldn't
work. I have discovered the mistake only yesterday.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: shmobile: BOCK-W: add Ether support
Date: Sun, 16 Jun 2013 20:14:12 +0400 [thread overview]
Message-ID: <51BDE454.5000006@cogentembedded.com> (raw)
In-Reply-To: <20130612140905.GM32751@verge.net.au>
Hello.
On 12.06.2013 18:09, Simon Horman wrote:
>> Register Ether device from bockw_init(), passing the platform data to it, adding
>> only the RMII pin group to bockw_pinctrl_map[]. Although the LINK signal exists
>> on the board, it's connected to the link/activity LED output of the PHY, thus
>> the link disappears and reappears after each packet. We'd be better off ignoring
>> such signal and getting the link state from the PHY indirectly.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> The patch is atop of Simon's 'renesas.git' repo, 'renesas-next-20130528' tag
>> and the USB patches just reposted. I decided to move it ahead of the VIN patches
>> as it can be merged right now since all dependecies have been already met.
> Thanks, queued up in the boards branch.
Has this been pulled by Olof/Arnd? If not, is it possible to amend
this patch or should I send an incremental one? I forgot to update the
platform device name from "sh-eth" to "r8a777x-ether" in the PinMux
table, in accordance to the R8A7778 Ether device name fix. It would be
good if this got into 3.11 as otherwise Ether support on BOCK-W wouldn't
work. I have discovered the mistake only yesterday.
WBR, Sergei
next prev parent reply other threads:[~2013-06-16 16:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 22:40 [PATCH v3] ARM: shmobile: BOCK-W: add Ether support Sergei Shtylyov
2013-06-01 22:40 ` Sergei Shtylyov
2013-06-12 14:09 ` Simon Horman
2013-06-12 14:09 ` Simon Horman
2013-06-16 16:14 ` Sergei Shtylyov [this message]
2013-06-16 16:14 ` Sergei Shtylyov
2013-06-17 2:10 ` Simon Horman
2013-06-17 2:10 ` Simon Horman
2013-06-15 20:47 ` Sergei Shtylyov
2013-06-15 20:47 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BDE454.5000006@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.