From: Timur Tabi <timur@tabi.org>
To: Markus Pargmann <mpa@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
devicetree-discuss@lists.ozlabs.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH v8 02/11] ASoC: imx-pcm-fiq: Introduce pcm-fiq-params
Date: Mon, 17 Jun 2013 06:39:55 -0500 [thread overview]
Message-ID: <51BEF58B.8070405@tabi.org> (raw)
In-Reply-To: <1371389117-19729-3-git-send-email-mpa@pengutronix.de>
Markus Pargmann wrote:
> #ifdef CONFIG_SND_SOC_IMX_PCM_FIQ
> -int imx_pcm_fiq_init(struct platform_device *pdev);
> +int imx_pcm_fiq_init(struct platform_device *pdev,
> + struct imx_pcm_fiq_params *params);
> void imx_pcm_fiq_exit(struct platform_device *pdev);
> #else
> -static inline int imx_pcm_fiq_init(struct platform_device *pdev)
> +static inline int imx_pcm_fiq_init(struct platform_device *pdev,
> + struct imx_pcm_fiq_params *params);
> {
> return -ENODEV;
> }
This won't compile on PowerPC, because of the ;
In file included from
/home/b04825/git/linux.alsa2/sound/soc/fsl/fsl_ssi.c:53:0:
/home/b04825/git/linux.alsa2/sound/soc/fsl/imx-pcm.h:65:1: error: expected
identifier or '(' before '{' token
/home/b04825/git/linux.alsa2/sound/soc/fsl/imx-pcm.h:63:19: warning:
'imx_pcm_fiq_init' used but never defined
--
Timur Tabi
WARNING: multiple messages have this Message-ID (diff)
From: timur@tabi.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 02/11] ASoC: imx-pcm-fiq: Introduce pcm-fiq-params
Date: Mon, 17 Jun 2013 06:39:55 -0500 [thread overview]
Message-ID: <51BEF58B.8070405@tabi.org> (raw)
In-Reply-To: <1371389117-19729-3-git-send-email-mpa@pengutronix.de>
Markus Pargmann wrote:
> #ifdef CONFIG_SND_SOC_IMX_PCM_FIQ
> -int imx_pcm_fiq_init(struct platform_device *pdev);
> +int imx_pcm_fiq_init(struct platform_device *pdev,
> + struct imx_pcm_fiq_params *params);
> void imx_pcm_fiq_exit(struct platform_device *pdev);
> #else
> -static inline int imx_pcm_fiq_init(struct platform_device *pdev)
> +static inline int imx_pcm_fiq_init(struct platform_device *pdev,
> + struct imx_pcm_fiq_params *params);
> {
> return -ENODEV;
> }
This won't compile on PowerPC, because of the ;
In file included from
/home/b04825/git/linux.alsa2/sound/soc/fsl/fsl_ssi.c:53:0:
/home/b04825/git/linux.alsa2/sound/soc/fsl/imx-pcm.h:65:1: error: expected
identifier or '(' before '{' token
/home/b04825/git/linux.alsa2/sound/soc/fsl/imx-pcm.h:63:19: warning:
'imx_pcm_fiq_init' used but never defined
--
Timur Tabi
next prev parent reply other threads:[~2013-06-17 11:39 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 13:25 [PATCH v8 00/11] ASoC: fsl-ssi: ac97-slave support Markus Pargmann
2013-06-16 13:25 ` Markus Pargmann
2013-06-16 13:25 ` [PATCH v8 01/11] ASoC: imx-pcm-dma: DT support Markus Pargmann
2013-06-16 13:25 ` Markus Pargmann
[not found] ` <1371389117-19729-1-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-06-16 13:25 ` [PATCH v8 02/11] ASoC: imx-pcm-fiq: Introduce pcm-fiq-params Markus Pargmann
2013-06-16 13:25 ` Markus Pargmann
2013-06-17 11:39 ` Timur Tabi [this message]
2013-06-17 11:39 ` Timur Tabi
2013-06-16 13:25 ` [PATCH v8 03/11] ASoC: fsl: Move soc_ac97_ops from imx-ssi to fsl_ssi Markus Pargmann
2013-06-16 13:25 ` Markus Pargmann
2013-06-16 13:25 ` [PATCH v8 04/11] ASoC: fsl-ssi: Add support for imx-pcm-fiq Markus Pargmann
2013-06-16 13:25 ` Markus Pargmann
2013-06-16 13:25 ` [PATCH v8 05/11] ASoC: fsl-ssi: Use generic DMA bindings if possible Markus Pargmann
2013-06-16 13:25 ` Markus Pargmann
2013-06-16 13:25 ` [PATCH v8 06/11] ASoC: fsl-ssi: imx ac97 support Markus Pargmann
2013-06-16 13:25 ` Markus Pargmann
2013-06-16 13:25 ` [PATCH v8 07/11] ARM: imx: Export ac97 reset functions Markus Pargmann
2013-06-16 13:25 ` Markus Pargmann
2013-06-16 13:25 ` [PATCH v8 08/11] ASoC: Add phycore-ac97-dt driver Markus Pargmann
2013-06-16 13:25 ` Markus Pargmann
2013-06-16 13:25 ` [PATCH v8 09/11] ASoC: fsl: Kconfig: Use fsl-ssi for phycore-ac97 Markus Pargmann
2013-06-16 13:25 ` Markus Pargmann
2013-06-16 13:25 ` [PATCH v8 11/11] ASoC: fsl: Update fsl-ssi binding doc Markus Pargmann
2013-06-16 13:25 ` Markus Pargmann
2013-06-17 2:36 ` [PATCH v8 00/11] ASoC: fsl-ssi: ac97-slave support Shawn Guo
2013-06-17 2:36 ` Shawn Guo
2013-06-20 12:53 ` Markus Pargmann
2013-06-20 12:53 ` Markus Pargmann
2013-06-16 13:25 ` [PATCH v8 10/11] ASoC: fsl: Move fsl-ssi binding doc to sound/ Markus Pargmann
2013-06-16 13:25 ` Markus Pargmann
2013-06-17 4:05 ` [PATCH v8 00/11] ASoC: fsl-ssi: ac97-slave support Timur Tabi
2013-06-17 4:05 ` Timur Tabi
[not found] ` <51BE8B21.8050605-N01EOCouUvQ@public.gmane.org>
2013-06-20 12:51 ` Markus Pargmann
2013-06-20 12:51 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BEF58B.8070405@tabi.org \
--to=timur@tabi.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=fabio.estevam@freescale.com \
--cc=grant.likely@secretlab.ca \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mpa@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.