Re: [GIT PULL 3/3] msm clock for 3.11

[Stephen Boyd <sboyd@codeaurora.org>]

On 06/14/13 18:35, Olof Johansson wrote:
> On Fri, Jun 14, 2013 at 12:52:55PM -0700, David Brown wrote:
>> The following changes since commit f722406faae2d073cc1d01063d1123c35425939e:
>>
>>  Linux 3.10-rc1 (2013-05-11 17:14:08 -0700)
>>
>> are available in the git repository at:
>>
>>  git://git.kernel.org/pub/scm/linux/kernel/git/davidb/linux-msm.git tags/msm-clock-for-3.11
>>
>> for you to fetch changes up to f54c1c11053d8aaf318a096b8b332fd41a394a66:
>>
>>  ARM: msm: Migrate to common clock framework (2013-06-12 14:43:31 -0700)
>>
>> ----------------------------------------------------------------
>> MSM clock updates for 3.11.
>>
>> Per Stephen Boyd's coverletter:
>>
>> This patchset moves the existing MSM clock code and affected drivers
>> to the common clock framework. A prerequisite of moving to the common
>> clock framework is to use clk_prepare() and clk_enable() so the first
>> few patches migrate drivers to that call (clk_prepare() is a no-op on
>> MSM right now). It also removes some custom clock APIs that MSM
>> provides and finally moves the proc_comm clock code to the common
>> struct clk.
>>
>> This patch series will be used as the foundation of the MSM 8660/8960
>> clock code that I plan to send out after this series.
>>
>> ----------------------------------------------------------------
>> Stephen Boyd (12):
>>      msm_serial: Convert to clk_prepare/unprepare
>>      msm_serial: Use devm_clk_get() and properly return errors
>>      usb: otg: msm: Convert to clk_prepare/unprepare
>>      msm_sdcc: Convert to clk_prepare/unprepare
>>      msm: iommu: Convert to clk_prepare/unprepare
>>      msm: iommu: Use clk_set_rate() instead of clk_set_min_rate()
>>      ARM: msm: Remove custom clk_set_flags() API
>>      ARM: msm: Remove custom clk_set_{max,min}_rate() API
>>      ARM: msm: Remove clock-7x30.h include file
>>      ARM: msm: Prepare clk_get() users in mach-msm for clock-pcom driver
>>      ARM: msm: Make proc_comm clock control into a platform driver
>>      ARM: msm: Migrate to common clock framework
> I don't see a single ack from any of the driver subsystem maintainers for
> serial, usb or iommu. Some of them have been acked though, for example Felipe
> acked the USB one on the mailing list.
>
> I also didn't see Greg cc:d on the serial patches, which would explain why
> there was no ack for them.
>
> Care to repost/collect/rebuild this branch, please? It's a great cleanup and
> I'd be happy to take it even if it ends up coming in after -rc6.

MAINTAINERS shows the MSM maintainers for the serial and mmc drivers so
I sent them to David. The iommu driver didn't seem to have any
maintainers entry so I just sent it off to David as well.

It wasn't clear to me that we needed to Cc higher level maintainers at
all. Perhaps we should clarify this in SubmittingPatches?

---8<-----

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 6e97e73..e87084f 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -152,6 +152,10 @@ if your change applies to a specific subsystem of the kernel, with
 an assigned maintainer.  If so, e-mail that person.  The script
 scripts/get_maintainer.pl can be very useful at this step.
 
+If there is a specific maintainer and a more general maintainer it's
+suggested that you email the more specific maintainer and Cc the more
+general maintainer and acquire their ack.
+
 If no maintainer is listed, or the maintainer does not respond, send
 your patch to the primary Linux kernel developer's mailing list,
 linux-kernel@vger.kernel.org.  Most kernel developers monitor this

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation