From: "Jiang Liu (Gerry)" <jiang.liu@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: Matthew Garrett <mjg@redhat.com>, Aaron Lu <aaron.lu@intel.com>,
Liu Jiang <liuj97@gmail.com>, Liu Jiang <liu97@gmail.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata: remove dead code from libata-acpi.c
Date: Tue, 18 Jun 2013 09:15:05 +0800 [thread overview]
Message-ID: <51BFB499.9050302@huawei.com> (raw)
In-Reply-To: <20130617180151.GG32663@mtj.dyndns.org>
On 2013/6/18 2:01, Tejun Heo wrote:
> On Mon, Jun 17, 2013 at 09:50:20AM +0800, Aaron Lu wrote:
>> On 06/15/2013 11:02 AM, Liu Jiang wrote:
>>> From: Liu Jiang <liu97@gmail.com>
>>>
>>> Commit 30dcf76acc69 "libata: migrate ACPI code over to new bindings"
>>> removed ACPI dock notification related code, but there's some dead
>>> code left, so clean up it.
>>
>> I never noticed this, but it looks to be the case...
>>
>> I'm not sure the dock notification code is removed intentionally or
>> mistakenly though, if it is a mistake, then instead of removing the left
>> code here, we probably should add the dock notification code back.
>>
>> But I have no test system or any knowledge about how ata dock works, so
>> I may be wrong :-)
>
> Looks like a regression to me. We're probably locking up on some
> older laptops which connects optical drives with hotpluggable PATA.
> Matthew, can you please fix it?
>
> Thanks.
>
Yeah, Aaron is right. We should restore the dock notification
handler to support ATA hotplug on some IBM laptops.
Regards!
Gerry
WARNING: multiple messages have this Message-ID (diff)
From: "Jiang Liu (Gerry)" <jiang.liu@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: Matthew Garrett <mjg@redhat.com>, Aaron Lu <aaron.lu@intel.com>,
Liu Jiang <liuj97@gmail.com>, Liu Jiang <liu97@gmail.com>,
<linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libata: remove dead code from libata-acpi.c
Date: Tue, 18 Jun 2013 09:15:05 +0800 [thread overview]
Message-ID: <51BFB499.9050302@huawei.com> (raw)
In-Reply-To: <20130617180151.GG32663@mtj.dyndns.org>
On 2013/6/18 2:01, Tejun Heo wrote:
> On Mon, Jun 17, 2013 at 09:50:20AM +0800, Aaron Lu wrote:
>> On 06/15/2013 11:02 AM, Liu Jiang wrote:
>>> From: Liu Jiang <liu97@gmail.com>
>>>
>>> Commit 30dcf76acc69 "libata: migrate ACPI code over to new bindings"
>>> removed ACPI dock notification related code, but there's some dead
>>> code left, so clean up it.
>>
>> I never noticed this, but it looks to be the case...
>>
>> I'm not sure the dock notification code is removed intentionally or
>> mistakenly though, if it is a mistake, then instead of removing the left
>> code here, we probably should add the dock notification code back.
>>
>> But I have no test system or any knowledge about how ata dock works, so
>> I may be wrong :-)
>
> Looks like a regression to me. We're probably locking up on some
> older laptops which connects optical drives with hotpluggable PATA.
> Matthew, can you please fix it?
>
> Thanks.
>
Yeah, Aaron is right. We should restore the dock notification
handler to support ATA hotplug on some IBM laptops.
Regards!
Gerry
next prev parent reply other threads:[~2013-06-18 1:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-15 3:02 [PATCH] libata: remove dead code from libata-acpi.c Liu Jiang
2013-06-17 1:50 ` Aaron Lu
2013-06-17 18:01 ` Tejun Heo
2013-06-18 1:15 ` Jiang Liu (Gerry) [this message]
2013-06-18 1:15 ` Jiang Liu (Gerry)
2013-06-18 9:16 ` Aaron Lu
2013-06-20 2:26 ` Aaron Lu
2013-06-20 11:02 ` Sergei Shtylyov
2013-06-21 0:55 ` Aaron Lu
2013-06-21 6:29 ` Tejun Heo
2013-06-21 6:48 ` Aaron Lu
2013-06-21 11:35 ` Sergei Shtylyov
2013-06-26 6:27 ` Aaron Lu
2013-06-21 15:25 ` James Bottomley
2013-06-26 2:01 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BFB499.9050302@huawei.com \
--to=jiang.liu@huawei.com \
--cc=aaron.lu@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liu97@gmail.com \
--cc=liuj97@gmail.com \
--cc=mjg@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.