[PATCH] selinux: umount $NEWROOT/dev and its submounts

[PATCH] selinux: umount $NEWROOT/dev and its submounts

[WANG Chao]

$NEWROOT/dev and its submounts should be umounted after we use it.
Otherwise it fails other scripts that umount /sysroot only.

Signed-off-by: WANG Chao <chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 modules.d/98selinux/selinux-loadpolicy.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/modules.d/98selinux/selinux-loadpolicy.sh b/modules.d/98selinux/selinux-loadpolicy.sh
index 5dddfc2..436ee6b 100755
--- a/modules.d/98selinux/selinux-loadpolicy.sh
+++ b/modules.d/98selinux/selinux-loadpolicy.sh
@@ -48,6 +48,7 @@ rd_load_policy()
             [ -e "$NEWROOT"/.autorelabel ] && LANG=C /usr/sbin/setenforce 0
             mount --rbind /dev "$NEWROOT/dev"
             LANG=C chroot "$NEWROOT" /sbin/restorecon -R /dev
+            umount -R "$NEWROOT/dev"
             return 0
         fi
 
-- 
1.8.2.1

Re: [PATCH] selinux: umount $NEWROOT/dev and its submounts

[Harald Hoyer]

On 06/18/2013 07:58 AM, WANG Chao wrote:
> $NEWROOT/dev and its submounts should be umounted after we use it.
> Otherwise it fails other scripts that umount /sysroot only.
> 
> Signed-off-by: WANG Chao <chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  modules.d/98selinux/selinux-loadpolicy.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/modules.d/98selinux/selinux-loadpolicy.sh b/modules.d/98selinux/selinux-loadpolicy.sh
> index 5dddfc2..436ee6b 100755
> --- a/modules.d/98selinux/selinux-loadpolicy.sh
> +++ b/modules.d/98selinux/selinux-loadpolicy.sh
> @@ -48,6 +48,7 @@ rd_load_policy()
>              [ -e "$NEWROOT"/.autorelabel ] && LANG=C /usr/sbin/setenforce 0
>              mount --rbind /dev "$NEWROOT/dev"
>              LANG=C chroot "$NEWROOT" /sbin/restorecon -R /dev
> +            umount -R "$NEWROOT/dev"
>              return 0
>          fi
>  
> 


Thanks! Pushed.