All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH v2 1/5] vnc: pass bool parameter for some functions
Date: Wed, 19 Jun 2013 12:17:59 +0400	[thread overview]
Message-ID: <51C16937.6060405@msgid.tls.msk.ru> (raw)
In-Reply-To: <1371527137-16949-1-git-send-email-lig.fnst@cn.fujitsu.com>

18.06.2013 07:45, liguang wrote:
> last parameters of vnc_listen_read,vnc_connect are bool,
> so pass 'false/true' instead of '0/1' for them.
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>

I think I'll apply my version instead, -- which converts remaining arguments
of functions your patch touches (so that we don't have this:

> -        vnc_connect(vs, csock, 0, 0);
> +        vnc_connect(vs, csock, 0, false);

where 3rd argument is also a bool), and which combines your patches 1/5
and 2/5 into one.

I'll resend it again in a top-level message.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 1/5] vnc: pass bool parameter for some functions
Date: Wed, 19 Jun 2013 12:17:59 +0400	[thread overview]
Message-ID: <51C16937.6060405@msgid.tls.msk.ru> (raw)
In-Reply-To: <1371527137-16949-1-git-send-email-lig.fnst@cn.fujitsu.com>

18.06.2013 07:45, liguang wrote:
> last parameters of vnc_listen_read,vnc_connect are bool,
> so pass 'false/true' instead of '0/1' for them.
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>

I think I'll apply my version instead, -- which converts remaining arguments
of functions your patch touches (so that we don't have this:

> -        vnc_connect(vs, csock, 0, 0);
> +        vnc_connect(vs, csock, 0, false);

where 3rd argument is also a bool), and which combines your patches 1/5
and 2/5 into one.

I'll resend it again in a top-level message.

Thanks,

/mjt

  parent reply	other threads:[~2013-06-19  8:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18  3:45 [Qemu-trivial] [PATCH v2 1/5] vnc: pass bool parameter for some functions liguang
2013-06-18  3:45 ` [Qemu-devel] " liguang
2013-06-18  3:45 ` [Qemu-trivial] [PATCH v2 2/5] vnc: boolize 'skipauth' liguang
2013-06-18  3:45   ` [Qemu-devel] " liguang
2013-06-18  3:45 ` [Qemu-trivial] [PATCH v2 3/5] qemu-char: use bool in qemu_chr_open_socket liguang
2013-06-18  3:45   ` [Qemu-devel] " liguang
2013-06-19  8:28   ` [Qemu-trivial] " Michael Tokarev
2013-06-19  8:28     ` [Qemu-devel] " Michael Tokarev
2013-06-20  0:21     ` li guang
2013-06-20  0:21       ` [Qemu-devel] " li guang
2013-06-18  3:45 ` [Qemu-trivial] [PATCH v2 4/5] sd: pass bool parameter for sd_init liguang
2013-06-18  3:45   ` [Qemu-devel] " liguang
2013-06-19  8:30   ` [Qemu-trivial] " Michael Tokarev
2013-06-19  8:30     ` [Qemu-devel] " Michael Tokarev
2013-06-18  3:45 ` [Qemu-trivial] [PATCH v2 5/5] ui: boolize 'full_screen' liguang
2013-06-18  3:45   ` [Qemu-devel] " liguang
2013-06-19  8:37   ` [Qemu-trivial] " Michael Tokarev
2013-06-19  8:37     ` [Qemu-devel] " Michael Tokarev
2013-06-19  8:17 ` Michael Tokarev [this message]
2013-06-19  8:17   ` [Qemu-devel] [Qemu-trivial] [PATCH v2 1/5] vnc: pass bool parameter for some functions Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C16937.6060405@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=lig.fnst@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.