From: Chen Gang <gang.chen@asianux.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
sam@ravnborg.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH] arch: sparc: prom: looping issue, need additional length check in the outside looping
Date: Wed, 19 Jun 2013 17:24:20 +0800 [thread overview]
Message-ID: <51C178C4.7030400@asianux.com> (raw)
In-Reply-To: <20130619.021342.853193458609177361.davem@davemloft.net>
On 06/19/2013 05:13 PM, David Miller wrote:
> From: Chen Gang <gang.chen@asianux.com>
> Date: Thu, 30 May 2013 11:35:22 +0800
>
>>
>> When "cp >= barg_buf + BARG_LEN-2", it breaks internel looping 'while',
>> but outside loop 'for' still has effect, so "*cp++ = ' '" will continue
>> repeating which may cause memory overflow.
>>
>> So need additional length check for it in the outside looping.
>>
>> Also beautify the related code which found by "./scripts/checkpatch.pl"
>
> Applied.
>
>
Thank you very much.
--
Chen Gang
Asianux Corporation
WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <gang.chen@asianux.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
sam@ravnborg.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH] arch: sparc: prom: looping issue, need additional length check in the outside looping
Date: Wed, 19 Jun 2013 09:24:20 +0000 [thread overview]
Message-ID: <51C178C4.7030400@asianux.com> (raw)
In-Reply-To: <20130619.021342.853193458609177361.davem@davemloft.net>
On 06/19/2013 05:13 PM, David Miller wrote:
> From: Chen Gang <gang.chen@asianux.com>
> Date: Thu, 30 May 2013 11:35:22 +0800
>
>>
>> When "cp >= barg_buf + BARG_LEN-2", it breaks internel looping 'while',
>> but outside loop 'for' still has effect, so "*cp++ = ' '" will continue
>> repeating which may cause memory overflow.
>>
>> So need additional length check for it in the outside looping.
>>
>> Also beautify the related code which found by "./scripts/checkpatch.pl"
>
> Applied.
>
>
Thank you very much.
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-06-19 9:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 3:35 [PATCH] arch: sparc: prom: looping issue, need additional length check in the outside looping Chen Gang
2013-05-30 3:35 ` Chen Gang
2013-06-19 9:13 ` David Miller
2013-06-19 9:13 ` David Miller
2013-06-19 9:24 ` Chen Gang [this message]
2013-06-19 9:24 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C178C4.7030400@asianux.com \
--to=gang.chen@asianux.com \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.