All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 1/2] cfg80211: require passing BSS struct back to cfg80211_assoc_timeout
Date: Wed, 19 Jun 2013 08:58:16 -0700	[thread overview]
Message-ID: <51C1D518.1060103@candelatech.com> (raw)
In-Reply-To: <1371650017-14293-1-git-send-email-johannes@sipsolutions.net>

On 06/19/2013 06:53 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Doing so will allow us to hold the BSS (not just ref it) over the
> association process, thus ensuring that it doesn't time out and
> gets invisible to the user (e.g. in 'iw wlan0 link'.)
>
> This also fixes a leak in mac80211 where it doesn't always release
> the BSS struct properly in all cases where calling this function.
> This leak was reported by Ben Greear.

I have not yet tested this, but I read it closely and
it appears to fix the same problem I tried to fix in
the 2/6 "Fix bss leak." patch.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  parent reply	other threads:[~2013-06-19 15:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-19 13:53 [PATCH 1/2] cfg80211: require passing BSS struct back to cfg80211_assoc_timeout Johannes Berg
2013-06-19 13:53 ` [PATCH 2/2] cfg80211: hold BSS over association process Johannes Berg
2013-06-19 16:03   ` Ben Greear
2013-06-19 20:28   ` Ben Greear
2013-06-19 20:36     ` Johannes Berg
2013-06-19 15:58 ` Ben Greear [this message]
2013-06-24 13:48 ` [PATCH 1/2] cfg80211: require passing BSS struct back to cfg80211_assoc_timeout Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C1D518.1060103@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.