From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 2/2] cfg80211: hold BSS over association process
Date: Wed, 19 Jun 2013 13:28:38 -0700 [thread overview]
Message-ID: <51C21476.2070401@candelatech.com> (raw)
In-Reply-To: <1371650017-14293-2-git-send-email-johannes@sipsolutions.net>
On 06/19/2013 06:53 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> This fixes the potential issue that the BSS struct that we use
> and later assign to wdev->current_bss is removed from the scan
> list while associating.
>
> Also warn when we don't have a BSS struct in connect_result
> unless it's from a driver that only has the connect() API.
I ran these two patches, plus my memory debugging patch
on top of wireless-testing (in relatively light testing).
It appears to fix the leaks I was seeing.
Just to make sure I am not missing something:
mac80211 should never take an additional reference
on the bss related to auth_data now?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2013-06-19 20:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 13:53 [PATCH 1/2] cfg80211: require passing BSS struct back to cfg80211_assoc_timeout Johannes Berg
2013-06-19 13:53 ` [PATCH 2/2] cfg80211: hold BSS over association process Johannes Berg
2013-06-19 16:03 ` Ben Greear
2013-06-19 20:28 ` Ben Greear [this message]
2013-06-19 20:36 ` Johannes Berg
2013-06-19 15:58 ` [PATCH 1/2] cfg80211: require passing BSS struct back to cfg80211_assoc_timeout Ben Greear
2013-06-24 13:48 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C21476.2070401@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.