From: "Steven J. Hill" <Steven.Hill@imgtec.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Tony Wu <tung7970@gmail.com>, <ralf@linux-mips.org>,
<macro@linux-mips.org>, <david.daney@cavium.com>,
<linux-mips@linux-mips.org>
Subject: Re: [PATCH v4 2/3] MIPS: microMIPS: Add kernel_uses_mmips in cpu-features.h
Date: Wed, 19 Jun 2013 16:56:17 -0500 [thread overview]
Message-ID: <51C22901.7050709@imgtec.com> (raw)
In-Reply-To: <51A36EE6.3040901@cogentembedded.com>
On 05/27/2013 09:34 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 27-05-2013 16:45, Tony Wu wrote:
>
>> Add kernel_uses_mmips to denote whether CONFIG_CPU_MICROMIPS
>> is set or not. This variable can help cut down #ifdef usage.
>
> You can avoid #ifdef usage with using IS_BUILTIN() macro, not
> defining extra macros.
>
>> Signed-off-by: Tony Wu <tung7970@gmail.com>
>> Cc: David Daney <david.daney@cavium.com>
>> Cc: Steven J. Hill <Steven.Hill@imgtec.com>
>
> WBR, Sergei
>
>
I think this patch is not needed with
<http://patchwork.linux-mips.org/patch/5327/> being used instead?
-Steve
WARNING: multiple messages have this Message-ID (diff)
From: "Steven J. Hill" <Steven.Hill@imgtec.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Tony Wu <tung7970@gmail.com>,
ralf@linux-mips.org, macro@linux-mips.org,
david.daney@cavium.com, linux-mips@linux-mips.org
Subject: Re: [PATCH v4 2/3] MIPS: microMIPS: Add kernel_uses_mmips in cpu-features.h
Date: Wed, 19 Jun 2013 16:56:17 -0500 [thread overview]
Message-ID: <51C22901.7050709@imgtec.com> (raw)
Message-ID: <20130619215617.0AdovnW9i9ktI6ijcxknMu7E4PnyQAzvsCJEVFFiBlo@z> (raw)
In-Reply-To: <51A36EE6.3040901@cogentembedded.com>
On 05/27/2013 09:34 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 27-05-2013 16:45, Tony Wu wrote:
>
>> Add kernel_uses_mmips to denote whether CONFIG_CPU_MICROMIPS
>> is set or not. This variable can help cut down #ifdef usage.
>
> You can avoid #ifdef usage with using IS_BUILTIN() macro, not
> defining extra macros.
>
>> Signed-off-by: Tony Wu <tung7970@gmail.com>
>> Cc: David Daney <david.daney@cavium.com>
>> Cc: Steven J. Hill <Steven.Hill@imgtec.com>
>
> WBR, Sergei
>
>
I think this patch is not needed with
<http://patchwork.linux-mips.org/patch/5327/> being used instead?
-Steve
next prev parent reply other threads:[~2013-06-19 21:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 12:44 [PATCH v4 1/3] MIPS: microMIPS: Fix POOL16C minor opcode enum Tony Wu
2013-05-27 12:45 ` [PATCH v4 2/3] MIPS: microMIPS: Add kernel_uses_mmips in cpu-features.h Tony Wu
2013-05-27 14:34 ` Sergei Shtylyov
2013-06-19 21:56 ` Steven J. Hill [this message]
2013-06-19 21:56 ` Steven J. Hill
2013-06-20 9:50 ` Tony Wu
2013-05-27 12:47 ` [PATCH v4 3/3] MIPS: microMIPS: Refactor get_frame_info support Tony Wu
2013-06-19 21:53 ` [PATCH v4 1/3] MIPS: microMIPS: Fix POOL16C minor opcode enum Steven J. Hill
2013-06-19 21:53 ` Steven J. Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C22901.7050709@imgtec.com \
--to=steven.hill@imgtec.com \
--cc=david.daney@cavium.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tung7970@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.