From: Lars-Peter Clausen <lars@metafoo.de>
To: Brian Austin <brian.austin@cirrus.com>,
Nicolas Schichan <nschichan@freebox.fr>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: cs42l52 alsa driver broken beep volume control
Date: Thu, 20 Jun 2013 10:34:26 +0200 [thread overview]
Message-ID: <51C2BE92.5020901@metafoo.de> (raw)
Hi,
I stumbled upon this while making some changes to the SOC_SINGLE_VALUE
macro. For the Beep Volume control the cs42l52 driver sets the invert field
to 7, which doesn't make much sense and is causing a build warning with my
changes. I assume the intention was to actually use SOC_SINGLE_SX_TLV
instead of SOC_SINGLE_TLV. But I'm not sure if setting min to 0x1f and max
0x7 is right either. Also according to the datasheet the tlv dB info seems
to be wrong. The Beep Volume uses 2dB steps while the info uses 0.5dB steps.
- Lars
next reply other threads:[~2013-06-20 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 8:34 Lars-Peter Clausen [this message]
2013-06-20 14:00 ` cs42l52 alsa driver broken beep volume control Brian Austin
2013-06-20 14:15 ` Brian Austin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C2BE92.5020901@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=nschichan@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.