* cs42l52 alsa driver broken beep volume control
@ 2013-06-20 8:34 Lars-Peter Clausen
2013-06-20 14:00 ` Brian Austin
2013-06-20 14:15 ` Brian Austin
0 siblings, 2 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2013-06-20 8:34 UTC (permalink / raw)
To: Brian Austin, Nicolas Schichan; +Cc: Linux-ALSA
Hi,
I stumbled upon this while making some changes to the SOC_SINGLE_VALUE
macro. For the Beep Volume control the cs42l52 driver sets the invert field
to 7, which doesn't make much sense and is causing a build warning with my
changes. I assume the intention was to actually use SOC_SINGLE_SX_TLV
instead of SOC_SINGLE_TLV. But I'm not sure if setting min to 0x1f and max
0x7 is right either. Also according to the datasheet the tlv dB info seems
to be wrong. The Beep Volume uses 2dB steps while the info uses 0.5dB steps.
- Lars
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: cs42l52 alsa driver broken beep volume control
2013-06-20 8:34 cs42l52 alsa driver broken beep volume control Lars-Peter Clausen
@ 2013-06-20 14:00 ` Brian Austin
2013-06-20 14:15 ` Brian Austin
1 sibling, 0 replies; 3+ messages in thread
From: Brian Austin @ 2013-06-20 14:00 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: Brian Austin, Linux-ALSA, Nicolas Schichan
On Thu, 20 Jun 2013, Lars-Peter Clausen wrote:
> Hi,
>
> I stumbled upon this while making some changes to the SOC_SINGLE_VALUE
> macro. For the Beep Volume control the cs42l52 driver sets the invert field
> to 7, which doesn't make much sense and is causing a build warning with my
> changes. I assume the intention was to actually use SOC_SINGLE_SX_TLV
> instead of SOC_SINGLE_TLV. But I'm not sure if setting min to 0x1f and max
> 0x7 is right either. Also according to the datasheet the tlv dB info seems
> to be wrong. The Beep Volume uses 2dB steps while the info uses 0.5dB steps.
>
> - Lars
>
>
Yes, I was supposed to use our SX Volume Control, and your correct the
step size is 2dB from -65dB. I believe the values are correct but I'll
have to do the math on it.
I can send a patch shortly.
Thanks,
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: cs42l52 alsa driver broken beep volume control
2013-06-20 8:34 cs42l52 alsa driver broken beep volume control Lars-Peter Clausen
2013-06-20 14:00 ` Brian Austin
@ 2013-06-20 14:15 ` Brian Austin
1 sibling, 0 replies; 3+ messages in thread
From: Brian Austin @ 2013-06-20 14:15 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: Brian Austin, Linux-ALSA, Nicolas Schichan
n Thu, 20 Jun 2013, Lars-Peter Clausen wrote:
> Hi,
>
> I stumbled upon this while making some changes to the SOC_SINGLE_VALUE
> macro. For the Beep Volume control the cs42l52 driver sets the invert field
> to 7, which doesn't make much sense and is causing a build warning with my
> changes. I assume the intention was to actually use SOC_SINGLE_SX_TLV
> instead of SOC_SINGLE_TLV. But I'm not sure if setting min to 0x1f and max
> 0x7 is right either. Also according to the datasheet the tlv dB info seems
> to be wrong. The Beep Volume uses 2dB steps while the info uses 0.5dB steps.
>
> - Lars
>
>
Yep, the min and max are backwards...
I'll fix it
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-20 14:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-20 8:34 cs42l52 alsa driver broken beep volume control Lars-Peter Clausen
2013-06-20 14:00 ` Brian Austin
2013-06-20 14:15 ` Brian Austin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.