All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org,
	Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	patches@linaro.org, qemu-devel@nongnu.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-trivial] [PATCH] Makefile: pass include directives to dtc via CPPFLAGS, not CFLAGS
Date: Fri, 21 Jun 2013 22:07:24 +0400	[thread overview]
Message-ID: <51C4965C.8020003@msgid.tls.msk.ru> (raw)
In-Reply-To: <1371819617-27232-1-git-send-email-peter.maydell@linaro.org>

21.06.2013 17:00, Peter Maydell wrote:
> The dtc submodule's makefile expects -I include directives to be
> in CPPFLAGS, not CFLAGS. Getting this wrong meant that the include
> directive would not be applied when generating the dependency .d
> files. This in turn meant that we couldn't build libfdt when
> doing an out of tree build with clang. (gcc's dependency output
> is slightly different from clang in this situation so it happened
> to work.)

Thanks, applied to the trivial patches queue, should be in the todays
poll request.

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org,
	Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	patches@linaro.org, qemu-devel@nongnu.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: pass include directives to dtc via CPPFLAGS, not CFLAGS
Date: Fri, 21 Jun 2013 22:07:24 +0400	[thread overview]
Message-ID: <51C4965C.8020003@msgid.tls.msk.ru> (raw)
In-Reply-To: <1371819617-27232-1-git-send-email-peter.maydell@linaro.org>

21.06.2013 17:00, Peter Maydell wrote:
> The dtc submodule's makefile expects -I include directives to be
> in CPPFLAGS, not CFLAGS. Getting this wrong meant that the include
> directive would not be applied when generating the dependency .d
> files. This in turn meant that we couldn't build libfdt when
> doing an out of tree build with clang. (gcc's dependency output
> is slightly different from clang in this situation so it happened
> to work.)

Thanks, applied to the trivial patches queue, should be in the todays
poll request.

/mjt

  reply	other threads:[~2013-06-21 18:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-21 13:00 [Qemu-trivial] [PATCH] Makefile: pass include directives to dtc via CPPFLAGS, not CFLAGS Peter Maydell
2013-06-21 13:00 ` [Qemu-devel] " Peter Maydell
2013-06-21 18:07 ` Michael Tokarev [this message]
2013-06-21 18:07   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C4965C.8020003@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=david@gibson.dropbear.id.au \
    --cc=patches@linaro.org \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.