* [Qemu-trivial] [PATCH] configure: Add signed*signed check to [u]int128_t test
@ 2013-06-21 13:01 ` Peter Maydell
0 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2013-06-21 13:01 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Richard Henderson, patches
clang 3.8 with -fsanitize=undefined will fail to link code containing an
int128_t * int128_t multiply (http://llvm.org/bugs/show_bug.cgi?id=16404)
so add this to our configure test for whether [u]int128_t are usable.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
configure | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure b/configure
index ad32f87..6465e05 100755
--- a/configure
+++ b/configure
@@ -3329,6 +3329,7 @@ __uint128_t b;
int main (void) {
a = a + b;
b = a * b;
+ a = a * a;
return 0;
}
EOF
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Qemu-devel] [PATCH] configure: Add signed*signed check to [u]int128_t test
@ 2013-06-21 13:01 ` Peter Maydell
0 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2013-06-21 13:01 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Richard Henderson, patches
clang 3.8 with -fsanitize=undefined will fail to link code containing an
int128_t * int128_t multiply (http://llvm.org/bugs/show_bug.cgi?id=16404)
so add this to our configure test for whether [u]int128_t are usable.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
configure | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure b/configure
index ad32f87..6465e05 100755
--- a/configure
+++ b/configure
@@ -3329,6 +3329,7 @@ __uint128_t b;
int main (void) {
a = a + b;
b = a * b;
+ a = a * a;
return 0;
}
EOF
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [PATCH] configure: Add signed*signed check to [u]int128_t test
2013-06-21 13:01 ` [Qemu-devel] " Peter Maydell
@ 2013-06-21 15:11 ` Richard Henderson
-1 siblings, 0 replies; 8+ messages in thread
From: Richard Henderson @ 2013-06-21 15:11 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
On 06/21/2013 06:01 AM, Peter Maydell wrote:
> clang 3.8 with -fsanitize=undefined will fail to link code containing an
> int128_t * int128_t multiply (http://llvm.org/bugs/show_bug.cgi?id=16404)
> so add this to our configure test for whether [u]int128_t are usable.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Add signed*signed check to [u]int128_t test
2013-06-21 13:01 ` [Qemu-devel] " Peter Maydell
@ 2013-06-21 15:13 ` Peter Maydell
-1 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2013-06-21 15:13 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, patches, Richard Henderson
On 21 June 2013 14:01, Peter Maydell <peter.maydell@linaro.org> wrote:
> clang 3.8 with -fsanitize=undefined will fail to link code containing an
> int128_t * int128_t multiply (http://llvm.org/bugs/show_bug.cgi?id=16404)
> so add this to our configure test for whether [u]int128_t are usable.
I meant "clang 3.3" here -- can this be fixed when the patch
is committed to -trivial or do you want a respin?
thanks
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] configure: Add signed*signed check to [u]int128_t test
2013-06-21 13:01 ` [Qemu-devel] " Peter Maydell
@ 2013-06-21 18:09 ` Michael Tokarev
-1 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2013-06-21 18:09 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, patches, qemu-devel, Richard Henderson
21.06.2013 17:01, Peter Maydell wrote:
> clang 3.8 with -fsanitize=undefined will fail to link code containing an
> int128_t * int128_t multiply (http://llvm.org/bugs/show_bug.cgi?id=16404)
> so add this to our configure test for whether [u]int128_t are usable.
I accept it as granted (with the fixup s/3.8/3.3/), I didn't try to verify
whenever it's actually true for clang.
Applied to the trivial patches queue (with the fixup), thanks!
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-06-21 21:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-21 13:01 [Qemu-trivial] [PATCH] configure: Add signed*signed check to [u]int128_t test Peter Maydell
2013-06-21 13:01 ` [Qemu-devel] " Peter Maydell
2013-06-21 15:11 ` [Qemu-trivial] " Richard Henderson
2013-06-21 15:11 ` [Qemu-devel] " Richard Henderson
2013-06-21 15:13 ` [Qemu-trivial] " Peter Maydell
2013-06-21 15:13 ` Peter Maydell
2013-06-21 18:09 ` [Qemu-trivial] " Michael Tokarev
2013-06-21 18:09 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.