All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH 03/13] qemu-socket: catch monitor_get_fd failures
Date: Fri, 21 Jun 2013 22:18:27 +0400	[thread overview]
Message-ID: <51C498F3.50608@msgid.tls.msk.ru> (raw)
In-Reply-To: <1371811105-730-4-git-send-email-kraxel@redhat.com>

21.06.2013 14:38, Gerd Hoffmann wrote:
>      case SOCKET_ADDRESS_KIND_FD:
>          fd = monitor_get_fd(cur_mon, addr->fd->str, errp);
> +        if (fd < 0) {
> +            break;
> +        }
>          if (callback) {
>              qemu_set_nonblock(fd);
>              callback(fd, opaque);

     case SOCKET_ADDRESS_KIND_FD:
         fd = monitor_get_fd(cur_mon, addr->fd->str, errp);
-        if (callback) {
+        if (fd >= 0 && callback) {
             qemu_set_nonblock(fd);
             callback(fd, opaque);
         }

?

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 03/13] qemu-socket: catch monitor_get_fd failures
Date: Fri, 21 Jun 2013 22:18:27 +0400	[thread overview]
Message-ID: <51C498F3.50608@msgid.tls.msk.ru> (raw)
In-Reply-To: <1371811105-730-4-git-send-email-kraxel@redhat.com>

21.06.2013 14:38, Gerd Hoffmann wrote:
>      case SOCKET_ADDRESS_KIND_FD:
>          fd = monitor_get_fd(cur_mon, addr->fd->str, errp);
> +        if (fd < 0) {
> +            break;
> +        }
>          if (callback) {
>              qemu_set_nonblock(fd);
>              callback(fd, opaque);

     case SOCKET_ADDRESS_KIND_FD:
         fd = monitor_get_fd(cur_mon, addr->fd->str, errp);
-        if (callback) {
+        if (fd >= 0 && callback) {
             qemu_set_nonblock(fd);
             callback(fd, opaque);
         }

?

Thanks,

/mjt

  reply	other threads:[~2013-06-21 18:18 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-21 10:38 [Qemu-trivial] [PATCH 00/13] A bunch of little socket + chardev fixes Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-devel] " Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-trivial] [PATCH 01/13] qemu-socket: zero-initialize SocketAddress Gerd Hoffmann
2013-06-21 10:38   ` [Qemu-devel] " Gerd Hoffmann
2013-06-21 18:15   ` [Qemu-trivial] " Michael Tokarev
2013-06-21 18:15     ` [Qemu-devel] " Michael Tokarev
2013-06-24  6:13     ` Gerd Hoffmann
2013-06-24  6:13       ` [Qemu-devel] " Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-trivial] [PATCH 02/13] qemu-socket: drop pointless allocation Gerd Hoffmann
2013-06-21 10:38   ` [Qemu-devel] " Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-trivial] [PATCH 03/13] qemu-socket: catch monitor_get_fd failures Gerd Hoffmann
2013-06-21 10:38   ` [Qemu-devel] " Gerd Hoffmann
2013-06-21 18:18   ` Michael Tokarev [this message]
2013-06-21 18:18     ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-21 10:38 ` [Qemu-trivial] [PATCH 04/13] qemu-char: check optional fields using has_* Gerd Hoffmann
2013-06-21 10:38   ` [Qemu-devel] " Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-trivial] [PATCH 05/13] qemu-char: use more specific error_setg_* variants Gerd Hoffmann
2013-06-21 10:38   ` [Qemu-devel] " Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-trivial] [PATCH 06/13] qemu-char: print notification to stderr Gerd Hoffmann
2013-06-21 10:38   ` [Qemu-devel] " Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-trivial] [PATCH 07/13] qemu-char: fix documentation for telnet+wait socket flags Gerd Hoffmann
2013-06-21 10:38   ` [Qemu-devel] " Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-trivial] [PATCH 08/13] qemu-char: don't leak opts on error Gerd Hoffmann
2013-06-21 10:38   ` [Qemu-devel] " Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-trivial] [PATCH 09/13] qemu-char: use ChardevBackendKind in in CharDriver Gerd Hoffmann
2013-06-21 10:38   ` [Qemu-devel] " Gerd Hoffmann
2013-06-21 18:36   ` [Qemu-trivial] " Michael Tokarev
2013-06-21 18:36     ` [Qemu-devel] " Michael Tokarev
2013-06-21 10:38 ` [Qemu-trivial] [PATCH 10/13] qemu-char: minor mux chardev fixes Gerd Hoffmann
2013-06-21 10:38   ` [Qemu-devel] " Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-trivial] [PATCH 11/13] qemu-char: add -chardev mux support Gerd Hoffmann
2013-06-21 10:38   ` [Qemu-devel] " Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-trivial] [PATCH 12/13] qemu-char: report udb backend errors Gerd Hoffmann
2013-06-21 10:38   ` [Qemu-devel] " Gerd Hoffmann
2013-06-21 10:38 ` [Qemu-trivial] [PATCH 13/13] qemu-socket: don't leak opts on error Gerd Hoffmann
2013-06-21 10:38   ` [Qemu-devel] " Gerd Hoffmann
2013-06-21 18:47 ` [Qemu-trivial] [PATCH 00/13] A bunch of little socket + chardev fixes Michael Tokarev
2013-06-21 18:47   ` [Qemu-devel] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C498F3.50608@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.