[ath9k-devel] ATH9K USB Injection CTS bad

[ath9k-devel] ATH9K USB Injection CTS bad

[C. McPherson]

Hi all:

The following problem has been noted in backports-3.10-rc1-1 and 
backports-3.10-rc1-2..

I am currently using a TP-LINK TL WN722N USB

When I am in the lab and I try to inject CTS frames while using the USB 
WiFi,  in monitor mode, I get malformed frames when running wireshark on 
another machine.  The captured frame looks like:


 From Remote Machine:

0000  00 00 12 00 2e 48 00 00  00 02 85 09 a0 00 ed 01   .....H.. ........
0010  00 00 c4 08 84 04 00 22  5f 77                     ......." _w


If I add the following code in  hif_usb_send_mgmt(), the CTS frame is 
formatted correctly and is displayed normally on the remote maching
running wireshark (see below):

         if (skb->data[16] == 0xc4)
                 skb->len += 2;


Modified version of ath9k_htc injecting the same cts frame as from above 
. Please notice that the baseline version truncates  the
receiver address.

0000  00 00 12 00 2e 48 00 00  00 02 85 09 a0 00 ed 01   .....H.. ........
0010  00 00 c4 08 84 04 00 22  5f 77 68 b0               ......." _wh.

String sending to mac80211/aht9k_htc via dumbnet:
"\x00\x00\x22\x00\x2f\x48\x00\x00\x89\xf5\xff\x45\x00\x00\x00\x00\x12\x04\x9e\x09\xa0\x00\xd0\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\xc4\x00\x84\x04\x00\x22\x5f\x77\x68\xb0\xf8\x26\x74\xae"


Please note the sending string contains the FCS and the Radiotap header 
flags have the FCS Flags set (The ieee80211_parse_tx_radiotap() function 
strips off
the FCS).



/var/log/messages:

IPv6: ADDRCONF(NETDEV_UP): wlan2: link is not ready
[14047.452015] device wlan2 entered promiscuous mode
[14303.097289] usbcore: deregistering interface driver ath9k_htc
[14303.113346] device wlan2 left promiscuous mode
[14303.149136] usb 1-1.1: ath9k_htc: USB layer deinitialized
[14303.149166] ath9k_htc: Driver unloaded
[14326.073355] Loading modules backported from Linux version 
v3.10-rc1-0-gf722406
[14326.073357] Backport generated by backports.git v3.10-rc1-1-0-g80112f6
[14326.075912] cfg80211: Calling CRDA to update world regulatory domain
[14326.079293] cfg80211: World regulatory domain updated:
[14326.079295] cfg80211:   (start_freq - end_freq @ bandwidth), 
(max_antenna_gain, max_eirp)
[14326.079297] cfg80211:   (2402000 KHz - 2472000 KHz @ 40000 KHz), (300 
mBi, 2000 mBm)
[14326.079298] cfg80211:   (2457000 KHz - 2482000 KHz @ 20000 KHz), (300 
mBi, 2000 mBm)
[14326.079299] cfg80211:   (2474000 KHz - 2494000 KHz @ 20000 KHz), (300 
mBi, 2000 mBm)
[14326.079300] cfg80211:   (5170000 KHz - 5250000 KHz @ 40000 KHz), (300 
mBi, 2000 mBm)
[14326.079301] cfg80211:   (5735000 KHz - 5835000 KHz @ 40000 KHz), (300 
mBi, 2000 mBm)
[14326.080043] usb 1-1.1: ath9k_htc: Firmware htc_9271.fw requested
[14326.080080] usbcore: registered new interface driver ath9k_htc
[14326.405019] usb 1-1.1: ath9k_htc: Transferred FW: htc_9271.fw, size: 
51272
[14326.639701] ath9k_htc 1-1.1:1.0: ath9k_htc: HTC initialized with 33 
credits
[14326.826820] ath9k_htc 1-1.1:1.0: ath9k_htc: FW Version: 1.3
[14326.826822] ath: EEPROM regdomain: 0x809c
[14326.826823] ath: EEPROM indicates we should expect a country code
[14326.826824] ath: doing EEPROM country->regdmn map search
[14326.826825] ath: country maps to regdmn code: 0x52
[14326.826826] ath: Country alpha2 being used: CN
[14326.826827] ath: Regpair used: 0x52
[14326.827054] ieee80211 phy0: Atheros AR9271 Rev:1
[14326.827197] cfg80211: Calling CRDA for country: CN
[14326.829692] cfg80211: Regulatory domain changed to country: CN
[14326.829694] cfg80211:   (start_freq - end_freq @ bandwidth), 
(max_antenna_gain, max_eirp)
[14326.829696] cfg80211:   (2402000 KHz - 2482000 KHz @ 40000 KHz), 
(N/A, 2000 mBm)
[14326.829697] cfg80211:   (5735000 KHz - 5835000 KHz @ 40000 KHz), 
(N/A, 3000 mBm)
[14326.829792] Registered led device: ath9k_htc-phy0
[14326.840711] IPv6: ADDRCONF(NETDEV_UP): wlan2: link is not ready
[15160.767239] device wlan2 entered promiscuous mode
[15184.325459] device wlan2 left promiscuous mode



Some Module information:

root at linuxbox:~/backports-3.10-rc1-1/net/mac80211# modinfo ath9k_htc
filename: 
/lib/modules/3.5.0-25-generic/updates/drivers/net/wireless/ath/ath9k/ath9k_htc.ko
firmware:       htc_9271.fw
firmware:       htc_7010.fw
version:        backported from Linux (v3.10-rc1-0-gf722406) using 
backports v3.10-rc1-1-0-g80112f6
description:    Atheros driver 802.11n HTC based wireless devices
license:        Dual BSD/GPL
author:         Atheros Communications
srcversion:     EE8705B925BB7C02D7D8DC8
alias:          usb:v0CF3p20FFd*dc*dsc*dp*ic*isc*ip*
alias:          usb:v04DAp3904d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v0411p017Fd*dc*dsc*dp*ic*isc*ip*
alias:          usb:v083ApA704d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v0846p9018d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v0CF3p7010d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v1668p1200d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v0CF3p7015d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v057Cp8403d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v0CF3pB002d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v0CF3pB003d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v040Dp3801d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v04CAp4605d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v13D3p3350d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v13D3p3349d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v13D3p3348d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v13D3p3346d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v13D3p3328d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v13D3p3327d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v07D1p3A10d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v0846p9030d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v0CF3p1006d*dc*dsc*dp*ic*isc*ip*
alias:          usb:v0CF3p9271d*dc*dsc*dp*ic*isc*ip*
depends:        mac80211,ath9k_hw,compat,ath9k_common,ath,cfg80211
vermagic:       3.5.0-25-generic SMP mod_unload modversions 686
parm:           debug:Debugging mask (uint)
parm:           nohwcrypt:Disable hardware encryption (int)
parm:           btcoex_enable:Enable wifi-BT coexistence (int)


OS - uname -r
3.5.0-25-generic




Thanks for your help
Clyde