From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, nobuhiro.iwamatsu.yj@renesas.com,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] sh_eth: fix unhandled RFE interrupt
Date: Mon, 24 Jun 2013 11:07:49 +0000 [thread overview]
Message-ID: <51C82885.8030607@cogentembedded.com> (raw)
In-Reply-To: <20130624.001044.2036651955086655996.davem@davemloft.net>
Hello.
On 24-06-2013 11:10, David Miller wrote:
>> EESR.RFE (receive FIFO overflow) interrupt is enabled by the driver on all SoCs
>> and sh_eth_error() handles it but it's not present in any initializer/assignment
>> of the 'eesr_err_check' field of 'struct sh_eth_cpu_data'. This leads to that
>> interrupt not being handled and cleared, and finally to disabling IRQ and the
>> driver being non-functional.
>> Modify DEFAULT_EESR_ERR_CHECK macro and all explicit initializers of the above
>> mentioned field to contain the EESR.RFE bit. Remove useless backslashes from the
>> initializers, while at it.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Applied to 'net'.
Queue it for -stable please, the bug goes back to the very start of
the driver development, it seems...
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, nobuhiro.iwamatsu.yj@renesas.com,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] sh_eth: fix unhandled RFE interrupt
Date: Mon, 24 Jun 2013 15:07:49 +0400 [thread overview]
Message-ID: <51C82885.8030607@cogentembedded.com> (raw)
In-Reply-To: <20130624.001044.2036651955086655996.davem@davemloft.net>
Hello.
On 24-06-2013 11:10, David Miller wrote:
>> EESR.RFE (receive FIFO overflow) interrupt is enabled by the driver on all SoCs
>> and sh_eth_error() handles it but it's not present in any initializer/assignment
>> of the 'eesr_err_check' field of 'struct sh_eth_cpu_data'. This leads to that
>> interrupt not being handled and cleared, and finally to disabling IRQ and the
>> driver being non-functional.
>> Modify DEFAULT_EESR_ERR_CHECK macro and all explicit initializers of the above
>> mentioned field to contain the EESR.RFE bit. Remove useless backslashes from the
>> initializers, while at it.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Applied to 'net'.
Queue it for -stable please, the bug goes back to the very start of
the driver development, it seems...
WBR, Sergei
next prev parent reply other threads:[~2013-06-24 11:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 21:12 [PATCH 1/2] sh_eth: fix unhandled RFE interrupt Sergei Shtylyov
2013-06-20 21:12 ` Sergei Shtylyov
2013-06-24 7:10 ` David Miller
2013-06-24 7:10 ` David Miller
2013-06-24 11:07 ` Sergei Shtylyov [this message]
2013-06-24 11:07 ` Sergei Shtylyov
2013-06-26 22:18 ` David Miller
2013-06-26 22:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C82885.8030607@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.