From: Stephen Warren <swarren@wwwdotorg.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, Shawn Guo <shawn.guo@linaro.org>,
Mark Brown <broonie@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH] ASoC: Tegra and i.MX are mutually exclusive
Date: Mon, 24 Jun 2013 09:28:08 -0600 [thread overview]
Message-ID: <51C86588.5020606@wwwdotorg.org> (raw)
In-Reply-To: <5967649.DUvDfofhX4@wuerfel>
On 06/24/2013 09:04 AM, Arnd Bergmann wrote:
> Both Tegra and i.MX provide ac97 operations, which can only
> exist once in the kernel. They can both be built as loadable
> modules (only one of them needs to be loaded anyway), but we
> have to disallow enabling them both as built-in.
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> menuconfig SND_IMX_SOC
> tristate "SoC Audio for Freescale i.MX CPUs"
> depends on ARCH_MXC
> + depends on SND_SOC_TEGRA=n || (SND_SOC_TEGRA=m && m)
I can easily see how this prevents adding SND_IMX_SOC to a config if
SND_SOC_TEGRA is enabled, but I'm not sure about the other way around;
does Kconfig check that adding a new SND_SOC_TEGRA wouldn't invalidate
any of the depends of any already-selected options?
In other words, do you need to make the "same" change to Tegra?
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: Tegra and i.MX are mutually exclusive
Date: Mon, 24 Jun 2013 09:28:08 -0600 [thread overview]
Message-ID: <51C86588.5020606@wwwdotorg.org> (raw)
In-Reply-To: <5967649.DUvDfofhX4@wuerfel>
On 06/24/2013 09:04 AM, Arnd Bergmann wrote:
> Both Tegra and i.MX provide ac97 operations, which can only
> exist once in the kernel. They can both be built as loadable
> modules (only one of them needs to be loaded anyway), but we
> have to disallow enabling them both as built-in.
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> menuconfig SND_IMX_SOC
> tristate "SoC Audio for Freescale i.MX CPUs"
> depends on ARCH_MXC
> + depends on SND_SOC_TEGRA=n || (SND_SOC_TEGRA=m && m)
I can easily see how this prevents adding SND_IMX_SOC to a config if
SND_SOC_TEGRA is enabled, but I'm not sure about the other way around;
does Kconfig check that adding a new SND_SOC_TEGRA wouldn't invalidate
any of the depends of any already-selected options?
In other words, do you need to make the "same" change to Tegra?
next prev parent reply other threads:[~2013-06-24 15:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 15:04 [PATCH] ASoC: Tegra and i.MX are mutually exclusive Arnd Bergmann
2013-06-24 15:04 ` Arnd Bergmann
2013-06-24 15:28 ` Stephen Warren [this message]
2013-06-24 15:28 ` Stephen Warren
2013-06-24 16:00 ` Arnd Bergmann
2013-06-24 16:00 ` Arnd Bergmann
2013-06-25 6:36 ` Lars-Peter Clausen
2013-06-25 6:36 ` [alsa-devel] " Lars-Peter Clausen
2013-06-25 9:26 ` Mark Brown
2013-06-25 9:26 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C86588.5020606@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.