Re: [PATCH v2 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once

[David Daney <ddaney.cavm@gmail.com>]

On 06/23/2013 02:38 PM, Aaro Koskinen wrote:
> When booting a new board for the first time, the console is flooded with
> "Unknown board" messages. This is not really helpful. Board type is not
> going to change after the boot, so it's sufficient to print the warning
> only once.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>

I don't think we need this patch.  In 2/2 you add the board type for the 
board you have, so you shouldn't be getting any messages, and this is 
unneeded.

I don't mind spamming people with all the messages,  if people see these 
messages, they have bigger problems than too many messages.

David Daney


> ---
>
> 	v2: Adjust indentation.
>
>   arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> index 7c64977..9838c0e 100644
> --- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> +++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> @@ -31,6 +31,8 @@
>    * network ports from the rest of the cvmx-helper files.
>    */
>
> +#include <linux/printk.h>
> +
>   #include <asm/octeon/octeon.h>
>   #include <asm/octeon/cvmx-bootinfo.h>
>
> @@ -184,9 +186,8 @@ int cvmx_helper_board_get_mii_address(int ipd_port)
>   	}
>
>   	/* Some unknown board. Somebody forgot to update this function... */
> -	cvmx_dprintf
> -	    ("cvmx_helper_board_get_mii_address: Unknown board type %d\n",
> -	     cvmx_sysinfo_get()->board_type);
> +	pr_warn_once("%s: Unknown board type %d\n", __func__,
> +		     cvmx_sysinfo_get()->board_type);
>   	return -1;
>   }
>
>