Re: [PATCH v2 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once

[David Daney <ddaney.cavm@gmail.com>]

On 06/24/2013 04:06 PM, Aaro Koskinen wrote:
> On Mon, Jun 24, 2013 at 03:33:36PM -0700, David Daney wrote:
>> On 06/24/2013 03:04 PM, Aaro Koskinen wrote:
>>> On Mon, Jun 24, 2013 at 11:52:23AM -0700, David Daney wrote:
>>>> On 06/23/2013 02:38 PM, Aaro Koskinen wrote:
>>>>> When booting a new board for the first time, the console is flooded with
>>>>> "Unknown board" messages. This is not really helpful. Board type is not
>>>>> going to change after the boot, so it's sufficient to print the warning
>>>>> only once.
>>>>>
>>>>> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>>>>
>>>> I don't think we need this patch.  In 2/2 you add the board type for
>>>> the board you have, so you shouldn't be getting any messages, and
>>>> this is unneeded.
>>>>
>>>> I don't mind spamming people with all the messages,  if people see
>>>> these messages, they have bigger problems than too many messages.
>>>
>>> I guess this patch can be dropped, but whoever tries to improve the
>>> support for the next new Octeon board will get annoyed by these same
>>> messages...
>>
>> I would hope that the "next new Octeon board" would have a
>> bootloader that supplies a device tree.  That way most of this would
>> never be used, and there would be no messages.
>
> Yes, actually I was wondering if MIPS kernel could offer something
> similar to ARM's APPENDED_DTB, i.e. provide some mechanism to pass the
> dtb if the bootloader support is missing.
>

Well the octeon port does supply its own device tree if one isn't passed 
from the bootloader.  And your patch 2/2 supplies the information used 
populate it.

But that is not quite the same I think.  It would be nice to be able to 
pass on the command line something.  Then you could load a blob from the 
boot ROM or similar and get something sensible.

David Daney