All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>,
	Riku Voipio <riku.voipio@iki.fi>
Cc: Jia Liu <proljc@gmail.com>,
	patches@linaro.org, Alexander Graf <agraf@suse.de>,
	qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	Guan Xuetao <gxt@mprc.pku.edu.cn>,
	Aurelien Jarno <aurelien@aurel32.net>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] linux-user: Move cpu_clone_regs() and cpu_set_tls() into linux-user
Date: Tue, 25 Jun 2013 13:49:34 +0200	[thread overview]
Message-ID: <51C983CE.6000506@suse.de> (raw)
In-Reply-To: <1372156544-31712-1-git-send-email-peter.maydell@linaro.org>

Am 25.06.2013 12:35, schrieb Peter Maydell:
> The functions cpu_clone_regs() and cpu_set_tls() are not purely CPU
> related -- they are specific to the TLS ABI for a a particular OS.
> Move them into the linux-user/ tree where they belong.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> The recent bsd-user patch series reminded me what a mess the
> current NPTL/threading status of linux-user is. I have some things
> in mind to clean it up (and maybe even actually get all targets
> up to having NPTL enabled, since it's mostly just implementing
> the two functions being moved here for x86, sparc, openrisc.
> 
> Andreas, I hope this doesn't cut across anything you were
> planning for your QOM tree.

This looks along the lines of what we had been discussing - I hadn't
worked on that yet, unsure where to put things.

Since it is touching on each cpu.h, I would prefer to take it through
qom-cpu queue if Riku doesn't object.

Regards,
Andreas

> 
> NB: copyright/license headers for the new header files are
> taken from the cpu.h that the functions came from. In a couple
> of cases where cpu.h had no license header I used the one from
> the corresponding translate.c.
> 
>  linux-user/alpha/target_cpu.h      |   36 +++++++++++++++++++++++++++++++
>  linux-user/arm/target_cpu.h        |   35 ++++++++++++++++++++++++++++++
>  linux-user/cris/target_cpu.h       |   36 +++++++++++++++++++++++++++++++
>  linux-user/i386/target_cpu.h       |   10 +++++++++
>  linux-user/m68k/target_cpu.h       |   34 ++++++++++++++++++++++++++++++
>  linux-user/microblaze/target_cpu.h |   35 ++++++++++++++++++++++++++++++
>  linux-user/mips/target_cpu.h       |   36 +++++++++++++++++++++++++++++++
>  linux-user/mips64/target_cpu.h     |    1 +
>  linux-user/openrisc/target_cpu.h   |   10 +++++++++
>  linux-user/ppc/target_cpu.h        |   41 ++++++++++++++++++++++++++++++++++++
>  linux-user/qemu.h                  |    1 +
>  linux-user/s390x/target_cpu.h      |   39 ++++++++++++++++++++++++++++++++++
>  linux-user/sh4/target_cpu.h        |   35 ++++++++++++++++++++++++++++++
>  linux-user/sparc/target_cpu.h      |   36 +++++++++++++++++++++++++++++++
>  linux-user/sparc64/target_cpu.h    |    1 +
>  linux-user/unicore32/target_cpu.h  |   27 ++++++++++++++++++++++++
>  linux-user/x86_64/target_cpu.h     |    1 +
>  target-alpha/cpu.h                 |   16 --------------
>  target-arm/cpu.h                   |   14 ------------
>  target-cris/cpu.h                  |   14 ------------
>  target-m68k/cpu.h                  |    9 --------
>  target-microblaze/cpu.h            |   14 ------------
>  target-mips/cpu.h                  |   13 ------------
>  target-ppc/cpu.h                   |   20 ------------------
>  target-s390x/cpu.h                 |   16 --------------
>  target-sh4/cpu.h                   |   14 ------------
>  target-sparc/cpu.h                 |   12 -----------
>  target-unicore32/cpu.h             |   13 ------------
>  28 files changed, 414 insertions(+), 155 deletions(-)
>  create mode 100644 linux-user/alpha/target_cpu.h
>  create mode 100644 linux-user/arm/target_cpu.h
>  create mode 100644 linux-user/cris/target_cpu.h
>  create mode 100644 linux-user/i386/target_cpu.h
>  create mode 100644 linux-user/m68k/target_cpu.h
>  create mode 100644 linux-user/microblaze/target_cpu.h
>  create mode 100644 linux-user/mips/target_cpu.h
>  create mode 100644 linux-user/mips64/target_cpu.h
>  create mode 100644 linux-user/openrisc/target_cpu.h
>  create mode 100644 linux-user/ppc/target_cpu.h
>  create mode 100644 linux-user/s390x/target_cpu.h
>  create mode 100644 linux-user/sh4/target_cpu.h
>  create mode 100644 linux-user/sparc/target_cpu.h
>  create mode 100644 linux-user/sparc64/target_cpu.h
>  create mode 100644 linux-user/unicore32/target_cpu.h
>  create mode 100644 linux-user/x86_64/target_cpu.h
[snip]

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2013-06-25 11:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-25 10:35 [Qemu-devel] [PATCH] linux-user: Move cpu_clone_regs() and cpu_set_tls() into linux-user Peter Maydell
2013-06-25 11:49 ` Andreas Färber [this message]
2013-06-27 18:33   ` Peter Maydell
2013-06-25 11:55 ` Edgar E. Iglesias
2013-06-25 12:04   ` Peter Maydell
2013-06-25 13:56 ` Richard Henderson
2013-06-25 14:07   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C983CE.6000506@suse.de \
    --to=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=blauwirbel@gmail.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=proljc@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.