All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlad Yasevich <vyasevich@gmail.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/6] Further SCTP changes
Date: Tue, 25 Jun 2013 17:54:56 +0000	[thread overview]
Message-ID: <51C9D970.2040102@gmail.com> (raw)
In-Reply-To: <1372177050-17829-1-git-send-email-dborkman@redhat.com>

On 06/25/2013 12:17 PM, Daniel Borkmann wrote:
> Mostly it's all about getting rid of unnecessary code, and/or making
> it more clean and readable. Code has been tested with lksctp-tools
> functional test suite and also my small sctp stress test helper that
> was used to discover the recent null-ptr derefs.
>
> v2->v3:
>    - Just changed "net: sctp: decouple cleaning some socket data from endpoint"
>      patch description slightly and made assignment explicit as Vlad requested
>    - Rest is unchanged
> v1->v2:
>    - Left sctp_put_port() still in sctp_endpoint_destroy() for now
>    - Added minor "net: sctp: simplify sctp_get_port" patch
>
> Daniel Borkmann (6):
>    net: sctp: remove TEST_FRAME ifdef
>    ktime: add ms_to_ktime() and ktime_add_ms() helpers
>    net: sctp: migrate cookie life from timeval to ktime
>    net: sctp: minor: sctp_seq_dump_local_addrs add missing newline
>    net: sctp: decouple cleaning some socket data from endpoint
>    net: sctp: simplify sctp_get_port

Acked-by: Vlad Yasevich <vyasevich@gmail.com>

-vlad

>
>   include/linux/ktime.h      | 13 +++++++++++++
>   include/net/sctp/sctp.h    | 25 -------------------------
>   include/net/sctp/structs.h |  6 +++---
>   net/sctp/associola.c       |  8 +-------
>   net/sctp/endpointola.c     | 19 ++++++++++---------
>   net/sctp/proc.c            |  2 +-
>   net/sctp/sm_make_chunk.c   | 19 ++++++++-----------
>   net/sctp/socket.c          | 35 +++++++++++++++++++----------------
>   8 files changed, 55 insertions(+), 72 deletions(-)
>


WARNING: multiple messages have this Message-ID (diff)
From: Vlad Yasevich <vyasevich@gmail.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/6] Further SCTP changes
Date: Tue, 25 Jun 2013 13:54:56 -0400	[thread overview]
Message-ID: <51C9D970.2040102@gmail.com> (raw)
In-Reply-To: <1372177050-17829-1-git-send-email-dborkman@redhat.com>

On 06/25/2013 12:17 PM, Daniel Borkmann wrote:
> Mostly it's all about getting rid of unnecessary code, and/or making
> it more clean and readable. Code has been tested with lksctp-tools
> functional test suite and also my small sctp stress test helper that
> was used to discover the recent null-ptr derefs.
>
> v2->v3:
>    - Just changed "net: sctp: decouple cleaning some socket data from endpoint"
>      patch description slightly and made assignment explicit as Vlad requested
>    - Rest is unchanged
> v1->v2:
>    - Left sctp_put_port() still in sctp_endpoint_destroy() for now
>    - Added minor "net: sctp: simplify sctp_get_port" patch
>
> Daniel Borkmann (6):
>    net: sctp: remove TEST_FRAME ifdef
>    ktime: add ms_to_ktime() and ktime_add_ms() helpers
>    net: sctp: migrate cookie life from timeval to ktime
>    net: sctp: minor: sctp_seq_dump_local_addrs add missing newline
>    net: sctp: decouple cleaning some socket data from endpoint
>    net: sctp: simplify sctp_get_port

Acked-by: Vlad Yasevich <vyasevich@gmail.com>

-vlad

>
>   include/linux/ktime.h      | 13 +++++++++++++
>   include/net/sctp/sctp.h    | 25 -------------------------
>   include/net/sctp/structs.h |  6 +++---
>   net/sctp/associola.c       |  8 +-------
>   net/sctp/endpointola.c     | 19 ++++++++++---------
>   net/sctp/proc.c            |  2 +-
>   net/sctp/sm_make_chunk.c   | 19 ++++++++-----------
>   net/sctp/socket.c          | 35 +++++++++++++++++++----------------
>   8 files changed, 55 insertions(+), 72 deletions(-)
>

  parent reply	other threads:[~2013-06-25 17:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-25 16:17 [PATCH net-next v3 0/6] Further SCTP changes Daniel Borkmann
2013-06-25 16:17 ` Daniel Borkmann
2013-06-25 16:17 ` [PATCH net-next v3 1/6] net: sctp: remove TEST_FRAME ifdef Daniel Borkmann
2013-06-25 16:17   ` Daniel Borkmann
2013-06-25 16:17 ` [PATCH net-next v3 2/6] ktime: add ms_to_ktime() and ktime_add_ms() helpers Daniel Borkmann
2013-06-25 16:17   ` Daniel Borkmann
2013-06-25 16:17 ` [PATCH net-next v3 3/6] net: sctp: migrate cookie life from timeval to ktime Daniel Borkmann
2013-06-25 16:17   ` Daniel Borkmann
2013-06-25 16:17 ` [PATCH net-next v3 4/6] net: sctp: minor: sctp_seq_dump_local_addrs add missing newline Daniel Borkmann
2013-06-25 16:17   ` Daniel Borkmann
2013-06-25 16:17 ` [PATCH net-next v3 5/6] net: sctp: decouple cleaning some socket data from endpoint Daniel Borkmann
2013-06-25 16:17   ` Daniel Borkmann
2013-06-25 16:17 ` [PATCH net-next v3 6/6] net: sctp: simplify sctp_get_port Daniel Borkmann
2013-06-25 16:17   ` Daniel Borkmann
2013-06-25 17:54 ` Vlad Yasevich [this message]
2013-06-25 17:54   ` [PATCH net-next v3 0/6] Further SCTP changes Vlad Yasevich
2013-06-25 23:31 ` David Miller
2013-06-25 23:31   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C9D970.2040102@gmail.com \
    --to=vyasevich@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=linux-sctp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.