* [PATCH -next] pinctrl: vt8500: wmt: remove redundant dev_err call in wmt_pinctrl_probe()
@ 2013-06-26 1:56 Wei Yongjun
2013-06-26 5:38 ` Tony Prisk
2013-06-27 8:33 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2013-06-26 1:56 UTC (permalink / raw)
To: linus.walleij, linux, axel.lin, maxime.ripard, swarren
Cc: yongjun_wei, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/pinctrl/vt8500/pinctrl-wmt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pinctrl/vt8500/pinctrl-wmt.c b/drivers/pinctrl/vt8500/pinctrl-wmt.c
index fb30edf3..0cc4335 100644
--- a/drivers/pinctrl/vt8500/pinctrl-wmt.c
+++ b/drivers/pinctrl/vt8500/pinctrl-wmt.c
@@ -570,10 +570,8 @@ int wmt_pinctrl_probe(struct platform_device *pdev,
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
data->base = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(data->base)) {
- dev_err(&pdev->dev, "failed to map memory resource\n");
+ if (IS_ERR(data->base))
return PTR_ERR(data->base);
- }
wmt_desc.pins = data->pins;
wmt_desc.npins = data->npins;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] pinctrl: vt8500: wmt: remove redundant dev_err call in wmt_pinctrl_probe()
2013-06-26 1:56 [PATCH -next] pinctrl: vt8500: wmt: remove redundant dev_err call in wmt_pinctrl_probe() Wei Yongjun
@ 2013-06-26 5:38 ` Tony Prisk
2013-06-27 8:33 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Tony Prisk @ 2013-06-26 5:38 UTC (permalink / raw)
To: Wei Yongjun
Cc: linus.walleij, axel.lin, maxime.ripard, swarren, yongjun_wei,
linux-kernel
On 26/06/13 13:56, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/pinctrl/vt8500/pinctrl-wmt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/vt8500/pinctrl-wmt.c b/drivers/pinctrl/vt8500/pinctrl-wmt.c
> index fb30edf3..0cc4335 100644
> --- a/drivers/pinctrl/vt8500/pinctrl-wmt.c
> +++ b/drivers/pinctrl/vt8500/pinctrl-wmt.c
> @@ -570,10 +570,8 @@ int wmt_pinctrl_probe(struct platform_device *pdev,
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> data->base = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(data->base)) {
> - dev_err(&pdev->dev, "failed to map memory resource\n");
> + if (IS_ERR(data->base))
> return PTR_ERR(data->base);
> - }
>
> wmt_desc.pins = data->pins;
> wmt_desc.npins = data->npins;
Acked-by: Tony Prisk <linux@prisktech.co.nz>
Regards
Tony P
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] pinctrl: vt8500: wmt: remove redundant dev_err call in wmt_pinctrl_probe()
2013-06-26 1:56 [PATCH -next] pinctrl: vt8500: wmt: remove redundant dev_err call in wmt_pinctrl_probe() Wei Yongjun
2013-06-26 5:38 ` Tony Prisk
@ 2013-06-27 8:33 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-06-27 8:33 UTC (permalink / raw)
To: Wei Yongjun
Cc: Tony Prisk, Axel Lin, Maxime Ripard, Stephen Warren, Wei Yongjun,
linux-kernel@vger.kernel.org
On Wed, Jun 26, 2013 at 3:56 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Patch applied with Tony's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-27 8:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-26 1:56 [PATCH -next] pinctrl: vt8500: wmt: remove redundant dev_err call in wmt_pinctrl_probe() Wei Yongjun
2013-06-26 5:38 ` Tony Prisk
2013-06-27 8:33 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.